From 5864ab577fa91e225789ce0d6fdb63db78e3ee9b Mon Sep 17 00:00:00 2001 From: hongpy <1046019339@qq.com> Date: Sun, 9 Oct 2022 11:04:57 +0800 Subject: [PATCH] Fix the bug that SpiLoader#closeResources may not record the exception when error occurs (#2890) --- .../src/main/java/com/alibaba/csp/sentinel/spi/SpiLoader.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sentinel-core/src/main/java/com/alibaba/csp/sentinel/spi/SpiLoader.java b/sentinel-core/src/main/java/com/alibaba/csp/sentinel/spi/SpiLoader.java index 4b78fb10..ffeeaa3e 100644 --- a/sentinel-core/src/main/java/com/alibaba/csp/sentinel/spi/SpiLoader.java +++ b/sentinel-core/src/main/java/com/alibaba/csp/sentinel/spi/SpiLoader.java @@ -505,7 +505,7 @@ public final class SpiLoader { try { closeable.close(); } catch (Exception e) { - if (firstException != null) { + if (firstException == null) { firstException = e; } }