crabapples
/
Sentinel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dashboard: Fix issue of memory leak in real-time monitoring page (#1905) 

* Fix issue of memory leak in metric.js
This commit is contained in:
zhangkai253 2020-12-28 14:04:40 +08:00 committed by GitHub
parent 38d97b59bd
commit 63aeb49c45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sentinel-dashboard/src/main/webapp/resources/app/scripts/controllers/metric.js
View File

@ -2,7 +2,7 @@ var app = angular.module('sentinelDashboardApp');
app.controller('MetricCtl', ['$scope', '$stateParams', 'MetricService', '$interval', '$timeout', app.controller('MetricCtl', ['$scope', '$stateParams', 'MetricService', '$interval', '$timeout',
function ($scope, $stateParams, MetricService, $interval, $timeout) { function ($scope, $stateParams, MetricService, $interval, $timeout) {
$scope.charts = [];
$scope.endTime = new Date(); $scope.endTime = new Date();
$scope.startTime = new Date(); $scope.startTime = new Date();
$scope.startTime.setMinutes($scope.endTime.getMinutes() - 30); $scope.startTime.setMinutes($scope.endTime.getMinutes() - 30);
@ -59,6 +59,11 @@ app.controller('MetricCtl', ['$scope', '$stateParams', 'MetricService', '$interv
$interval.cancel(intervalId); $interval.cancel(intervalId);
}); });
$scope.initAllChart = function () { $scope.initAllChart = function () {
//revoke useless charts positively
while($scope.charts.length > 0) {
let chart = $scope.charts.pop();
chart.destroy();
}
$.each($scope.metrics, function (idx, metric) { $.each($scope.metrics, function (idx, metric) {
if (idx == $scope.metrics.length - 1) { if (idx == $scope.metrics.length - 1) {
return; return;
@ -70,6 +75,7 @@ app.controller('MetricCtl', ['$scope', '$stateParams', 'MetricService', '$interv
height: 250, height: 250,
padding: [10, 30, 70, 50] padding: [10, 30, 70, 50]
}); });
$scope.charts.push(chart);
var maxQps = 0; var maxQps = 0;
for (var i in metric.data) { for (var i in metric.data) {
var item = metric.data[i]; var item = metric.data[i];