Polish code in Dubbo adapter and use Dubbo common constants (#1245)

This commit is contained in:
echooymxq 2020-01-13 09:39:06 +08:00 committed by Eric Zhao
parent fe23d5c11f
commit 9cc52706f5
6 changed files with 18 additions and 6 deletions

View File

@ -24,12 +24,14 @@ import org.apache.dubbo.rpc.Result;
import org.apache.dubbo.rpc.RpcContext;
import org.apache.dubbo.rpc.RpcException;
import static org.apache.dubbo.common.constants.CommonConstants.CONSUMER;
/**
* Puts current consumer's application name in the attachment of each invocation.
*
* @author Eric Zhao
*/
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class DubboAppContextFilter implements Filter {
@Override

View File

@ -32,6 +32,8 @@ import org.apache.dubbo.rpc.RpcContext;
import org.apache.dubbo.rpc.RpcException;
import org.apache.dubbo.rpc.support.RpcUtils;
import static org.apache.dubbo.common.constants.CommonConstants.CONSUMER;
/**
* <p>Dubbo service consumer filter for Sentinel. Auto activated by default.</p>
* <p>
@ -43,7 +45,7 @@ import org.apache.dubbo.rpc.support.RpcUtils;
* @author Carpenter Lee
* @author Eric Zhao
*/
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class SentinelDubboConsumerFilter extends BaseSentinelDubboFilter {
public SentinelDubboConsumerFilter() {

View File

@ -31,6 +31,8 @@ import org.apache.dubbo.rpc.Result;
import org.apache.dubbo.rpc.RpcContext;
import org.apache.dubbo.rpc.RpcException;
import static org.apache.dubbo.common.constants.CommonConstants.PROVIDER;
/**
* <p>Apache Dubbo service provider filter that enables integration with Sentinel. Auto activated by default.</p>
* <p>Note: this only works for Apache Dubbo 2.7.x or above version.</p>
@ -43,7 +45,7 @@ import org.apache.dubbo.rpc.RpcException;
* @author Carpenter Lee
* @author Eric Zhao
*/
@Activate(group = "provider")
@Activate(group = PROVIDER)
public class SentinelDubboProviderFilter extends BaseSentinelDubboFilter {
public SentinelDubboProviderFilter() {

View File

@ -24,12 +24,14 @@ import com.alibaba.dubbo.rpc.Result;
import com.alibaba.dubbo.rpc.RpcContext;
import com.alibaba.dubbo.rpc.RpcException;
import static com.alibaba.dubbo.common.Constants.CONSUMER;
/**
* Puts current consumer's application name in the attachment of each invocation.
*
* @author Eric Zhao
*/
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class DubboAppContextFilter implements Filter {
@Override

View File

@ -31,6 +31,8 @@ import com.alibaba.dubbo.rpc.Invoker;
import com.alibaba.dubbo.rpc.Result;
import com.alibaba.dubbo.rpc.RpcException;
import static com.alibaba.dubbo.common.Constants.CONSUMER;
/**
* <p>Dubbo service consumer filter for Sentinel. Auto activated by default.</p>
*
@ -42,7 +44,7 @@ import com.alibaba.dubbo.rpc.RpcException;
* @author leyou
* @author Eric Zhao
*/
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class SentinelDubboConsumerFilter extends AbstractDubboFilter implements Filter {
public SentinelDubboConsumerFilter() {

View File

@ -32,6 +32,8 @@ import com.alibaba.dubbo.rpc.Invoker;
import com.alibaba.dubbo.rpc.Result;
import com.alibaba.dubbo.rpc.RpcException;
import static com.alibaba.dubbo.common.Constants.PROVIDER;
/**
* <p>Dubbo service provider filter for Sentinel. Auto activated by default.</p>
*
@ -43,7 +45,7 @@ import com.alibaba.dubbo.rpc.RpcException;
* @author leyou
* @author Eric Zhao
*/
@Activate(group = "provider")
@Activate(group = PROVIDER)
public class SentinelDubboProviderFilter extends AbstractDubboFilter implements Filter {
public SentinelDubboProviderFilter() {