crabapples
/
Sentinel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refine the methods and variable name in SlotChainProvider (#871)

This commit is contained in:
yidadi 2019-06-27 16:50:43 +08:00 committed by Eric Zhao
parent ba146765e3
commit c14e3296cb
1 changed files with 12 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
sentinel-core/src/main/java/com/alibaba/csp/sentinel/slotchain/SlotChainProvider.java
View File

@ -15,12 +15,9 @@
*/ */
package com.alibaba.csp.sentinel.slotchain; package com.alibaba.csp.sentinel.slotchain;
import java.util.ArrayList;
import java.util.List;
import java.util.ServiceLoader;
import com.alibaba.csp.sentinel.log.RecordLog; import com.alibaba.csp.sentinel.log.RecordLog;
import com.alibaba.csp.sentinel.slots.DefaultSlotChainBuilder; import com.alibaba.csp.sentinel.slots.DefaultSlotChainBuilder;
import java.util.ServiceLoader;
/** /**
* A provider for creating slot chains via resolved slot chain builder SPI. * A provider for creating slot chains via resolved slot chain builder SPI.
@ -30,7 +27,7 @@ import com.alibaba.csp.sentinel.slots.DefaultSlotChainBuilder;
*/ */
public final class SlotChainProvider { public final class SlotChainProvider {
private static volatile SlotChainBuilder builder = null; private static volatile SlotChainBuilder slotChainBuilder = null;
private static final ServiceLoader<SlotChainBuilder> LOADER = ServiceLoader.load(SlotChainBuilder.class); private static final ServiceLoader<SlotChainBuilder> LOADER = ServiceLoader.load(SlotChainBuilder.class);
@ -41,37 +38,33 @@ public final class SlotChainProvider {
* @return new created slot chain * @return new created slot chain
*/ */
public static ProcessorSlotChain newSlotChain() { public static ProcessorSlotChain newSlotChain() {
if (builder != null) { if (slotChainBuilder != null) {
return builder.build(); return slotChainBuilder.build();
} }
resolveSlotChainBuilder(); resolveSlotChainBuilder();
if (builder == null) { if (slotChainBuilder == null) {
RecordLog.warn("[SlotChainProvider] Wrong state when resolving slot chain builder, using default"); RecordLog.warn("[SlotChainProvider] Wrong state when resolving slot chain builder, using default");
builder = new DefaultSlotChainBuilder(); slotChainBuilder = new DefaultSlotChainBuilder();
} }
return builder.build(); return slotChainBuilder.build();
} }
private static void resolveSlotChainBuilder() { private static void resolveSlotChainBuilder() {
List<SlotChainBuilder> list = new ArrayList<SlotChainBuilder>();
boolean hasOther = false;
for (SlotChainBuilder builder : LOADER) { for (SlotChainBuilder builder : LOADER) {
if (builder.getClass() != DefaultSlotChainBuilder.class) { if (builder.getClass() != DefaultSlotChainBuilder.class) {
hasOther = true; slotChainBuilder = builder;
list.add(builder); break;
} }
} }
if (hasOther) { if (slotChainBuilder == null){
builder = list.get(0);
} else {
// No custom builder, using default. // No custom builder, using default.
builder = new DefaultSlotChainBuilder(); slotChainBuilder = new DefaultSlotChainBuilder();
} }
RecordLog.info("[SlotChainProvider] Global slot chain builder resolved: " RecordLog.info("[SlotChainProvider] Global slot chain builder resolved: "
+ builder.getClass().getCanonicalName()); + slotChainBuilder.getClass().getCanonicalName());
} }
private SlotChainProvider() {} private SlotChainProvider() {}