crabapples
/
Sentinel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve consumer filter of Dubbo 2.6.x and 2.7.x adapter (#1532) 

* entry and exit with params in consumer filter
This commit is contained in:
wavesZh 2020-06-11 15:51:33 +08:00 committed by GitHub
parent a1e3715db1
commit f1b63315c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
sentinel-adapter/sentinel-apache-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboConsumerFilter.java
View File

@ -98,7 +98,7 @@ public class SentinelDubboConsumerFilter extends BaseSentinelDubboFilter {
throw e; throw e;
} finally { } finally {
if (methodEntry != null) { if (methodEntry != null) {
methodEntry.exit(); methodEntry.exit(1, invocation.getArguments());
} }
if (interfaceEntry != null) { if (interfaceEntry != null) {
interfaceEntry.exit(); interfaceEntry.exit();
@ -108,32 +108,49 @@ public class SentinelDubboConsumerFilter extends BaseSentinelDubboFilter {
private Result asyncInvoke(Invoker<?> invoker, Invocation invocation) { private Result asyncInvoke(Invoker<?> invoker, Invocation invocation) {
LinkedList<Entry> queue = new LinkedList<>(); LinkedList<EntryHolder> queue = new LinkedList<>();
String methodResourceName = getMethodName(invoker, invocation); String methodResourceName = getMethodName(invoker, invocation);
String interfaceResourceName = getInterfaceName(invoker); String interfaceResourceName = getInterfaceName(invoker);
try { try {
queue.push(SphU.asyncEntry(interfaceResourceName, ResourceTypeConstants.COMMON_RPC, EntryType.OUT)); queue.push(new EntryHolder(SphU.asyncEntry(interfaceResourceName, ResourceTypeConstants.COMMON_RPC, EntryType.OUT), null));
queue.push(SphU.asyncEntry(methodResourceName, ResourceTypeConstants.COMMON_RPC, EntryType.OUT, 1, invocation.getArguments())); queue.push(new EntryHolder(SphU.asyncEntry(methodResourceName, ResourceTypeConstants.COMMON_RPC, EntryType.OUT, 1, invocation.getArguments()), invocation.getArguments()));
Result result = invoker.invoke(invocation); Result result = invoker.invoke(invocation);
result.whenCompleteWithContext(new BiConsumer<Result, Throwable>() { result.whenCompleteWithContext(new BiConsumer<Result, Throwable>() {
@Override @Override
public void accept(Result result, Throwable throwable) { public void accept(Result result, Throwable throwable) {
while (!queue.isEmpty()) { while (!queue.isEmpty()) {
Entry entry = queue.pop(); EntryHolder holder = queue.pop();
Tracer.traceEntry(result.getException(), entry); Tracer.traceEntry(result.getException(), holder.entry);
entry.exit(); exitEntry(holder);
} }
} }
}); });
return result; return result;
} catch (BlockException e) { } catch (BlockException e) {
while (!queue.isEmpty()) { while (!queue.isEmpty()) {
queue.pop().exit(); exitEntry(queue.pop());
} }
return DubboFallbackRegistry.getConsumerFallback().handle(invoker, invocation, e); return DubboFallbackRegistry.getConsumerFallback().handle(invoker, invocation, e);
} }
} }
class EntryHolder {
final private Entry entry;
final private Object[] params;
public EntryHolder(Entry entry, Object[] params) {
this.entry = entry;
this.params = params;
}
}
private void exitEntry(EntryHolder holder) {
if (holder.params != null) {
holder.entry.exit(1, holder.params);
} else {
holder.entry.exit();
}
}
} }

4
sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboConsumerFilter.java
View File

@ -59,7 +59,7 @@ public class SentinelDubboConsumerFilter extends AbstractDubboFilter implements
String resourceName = getResourceName(invoker, invocation, DubboConfig.getDubboConsumerPrefix()); String resourceName = getResourceName(invoker, invocation, DubboConfig.getDubboConsumerPrefix());
interfaceEntry = SphU.entry(invoker.getInterface().getName(), ResourceTypeConstants.COMMON_RPC, interfaceEntry = SphU.entry(invoker.getInterface().getName(), ResourceTypeConstants.COMMON_RPC,
EntryType.OUT); EntryType.OUT);
methodEntry = SphU.entry(resourceName, ResourceTypeConstants.COMMON_RPC, EntryType.OUT); methodEntry = SphU.entry(resourceName, ResourceTypeConstants.COMMON_RPC, EntryType.OUT, invocation.getArguments());
Result result = invoker.invoke(invocation); Result result = invoker.invoke(invocation);
if (result.hasException()) { if (result.hasException()) {
@ -77,7 +77,7 @@ public class SentinelDubboConsumerFilter extends AbstractDubboFilter implements
throw e; throw e;
} finally { } finally {
if (methodEntry != null) { if (methodEntry != null) {
methodEntry.exit(); methodEntry.exit(1, invocation.getArguments());
} }
if (interfaceEntry != null) { if (interfaceEntry != null) {
interfaceEntry.exit(); interfaceEntry.exit();