Merge 73a6b8c9a2 into 394ad22be9

.gitignore

@@ -1,5 +1,7 @@
 *.pyc
 *.o
+inflator/inflator-merged.js
+inflator/pako
 tests/data_*.js
 utils/rebind.so
 utils/websockify

app/locale/de.js

@@ -5,7 +5,10 @@
  * DO NOT EDIT!
  */
 
-Language = {
+"use strict";
+
+define(function() {
+return {
     "Connecting...": "Verbunden...",
     "Connected (encrypted) to ": "Verbunden mit (verschlüsselt) ",
     "Connected (unencrypted) to ": "Verbunden mit (unverschlüsselt) ",
@@ -16,3 +19,4 @@ Language = {
     "Forcing clipping mode since scrollbars aren't supported by IE in fullscreen": "'Clipping-Modus' aktiviert, Scrollbalken in 'IE-Vollbildmodus' werden nicht unterstützt",
     "Disconnect timeout": "Timeout beim trennen",
 };
+});

app/locale/el.js

@@ -5,7 +5,10 @@
  * DO NOT EDIT!
  */
 
-Language = {
+"use strict";
+
+define(function() {
+return {
     "Connecting...": "Συνδέεται...",
     "Connected (encrypted) to ": "Συνδέθηκε (κρυπτογραφημένα) με το ",
     "Connected (unencrypted) to ": "Συνδέθηκε (μη κρυπτογραφημένα) με το ",
@@ -72,3 +75,4 @@ Language = {
     "Send Password": "Αποστολή Κωδικού Πρόσβασης",
     "Canvas not supported.": "Δεν υποστηρίζεται το στοιχείο Canvas",
 };
+});

app/locale/nl.js

@@ -5,7 +5,10 @@
  * DO NOT EDIT!
  */
 
-Language = {
+"use strict";
+
+define(function() {
+return {
     "Connecting...": "Verbinden...",
     "Connected (encrypted) to ": "Verbonden (versleuteld) met ",
     "Connected (unencrypted) to ": "Verbonden (onversleuteld) met ",
@@ -16,3 +19,4 @@ Language = {
     "Forcing clipping mode since scrollbars aren't supported by IE in fullscreen": "''Clipping mode' ingeschakeld, omdat schuifbalken in volledige-scherm-modus in IE niet worden ondersteund",
     "Disconnect timeout": "Timeout tijdens verbreken van verbinding",
 };
+});

app/locale/sv.js

@@ -5,7 +5,10 @@
  * DO NOT EDIT!
  */
 
-Language = {
+"use strict";
+
+define(function() {
+return {
     "Connecting...": "Ansluter...",
     "Connected (encrypted) to ": "Ansluten (krypterat) till ",
     "Connected (unencrypted) to ": "Ansluten (okrypterat) till ",
@@ -75,3 +78,4 @@ Language = {
     "Send Password": "Skicka Lösenord",
     "Canvas not supported.": "Canvas stöds ej",
 };
+});

app/novnc.js

@@ -0,0 +1,22 @@
+/*
+ * noVNC: HTML5 VNC client
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
+ * Licensed under MPL 2.0 (see LICENSE.txt)
+ *
+ * See README.md for usage and integration instructions.
+ */
+
+/* jslint white: false, browser: true */
+
+"use strict";
+
+requirejs.config({
+    baseUrl: '',
+});
+
+requirejs(['app/ui', 'core/util'],
+function(ui, util) {
+    // Set up translations, then start the UI
+    var LINGUAS = ["de", "el", "nl", "sv"];
+    util.Localisation.setup(LINGUAS, "app/locale", ui.load);
+});

app/ui.js

@@ -2,28 +2,19 @@
  * noVNC: HTML5 VNC client
  * Copyright (C) 2012 Joel Martin
  * Copyright (C) 2016 Samuel Mannehed for Cendio AB
- * Copyright (C) 2016 Pierre Ossman for Cendio AB
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
  * Licensed under MPL 2.0 (see LICENSE.txt)
  *
  * See README.md for usage and integration instructions.
  */
 
 /* jslint white: false, browser: true */
-/* global window, document.getElementById, Util, WebUtil, RFB, Display */
 
-/* [module]
+"use strict";
- * import Util from "../core/util";
- * import KeyTable from "../core/input/keysym";
- * import keysyms from "./keysymdef";
- * import RFB from "../core/rfb";
- * import Display from "../core/display";
- * import WebUtil from "./webutil";
- */
 
-var UI;
+define(["app/webutil", "core/rfb", "core/util",
-
+        "core/input/keysym", "core/input/keysymdef"],
-(function () {
+function (WebUtil, rfb, Util, KeyTable, keysyms) {
-    "use strict";
 
     // Fallback for all uncought errors
     window.addEventListener('error', function(event) {
@@ -65,27 +56,9 @@ var UI;
         return false;
     });
 
-    // Set up translations
-    var LINGUAS = ["de", "el", "nl", "sv"];
-    Util.Localisation.setup(LINGUAS);
-    if (Util.Localisation.language !== "en") {
-        WebUtil.load_scripts(
-            {'app': ["locale/" + Util.Localisation.language + ".js"]});
-    }
-
-    /* [begin skip-as-module] */
-    // Load supporting scripts
-    WebUtil.load_scripts(
-        {'core': ["base64.js", "websock.js", "des.js", "input/keysymdef.js",
-                  "input/xtscancodes.js", "input/util.js", "input/devices.js",
-                  "display.js", "inflator.js", "rfb.js", "input/keysym.js"]});
-
-    window.onscriptsload = function () { UI.load(); };
-    /* [end skip-as-module] */
-
     var _ = Util.Localisation.get;
 
-    UI = {
+    var UI = {
 
         connected: false,
         desktopName: "",
@@ -397,7 +370,7 @@ var UI;
 
         initRFB: function() {
             try {
-                UI.rfb = new RFB({'target': document.getElementById('noVNC_canvas'),
+                UI.rfb = new rfb.RFB({'target': document.getElementById('noVNC_canvas'),
                                       'onNotification': UI.notification,
                                       'onUpdateState': UI.updateState,
                                       'onDisconnected': UI.disconnectFinished,
@@ -1732,7 +1705,5 @@ var UI;
  */
     };
 
-    /* [module] UI.load(); */
+    return UI;
-})();
+});
-
-/* [module] export default UI; */

app/webutil.js

@@ -2,42 +2,32 @@
  * noVNC: HTML5 VNC client
  * Copyright (C) 2012 Joel Martin
  * Copyright (C) 2013 NTT corp.
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
  * Licensed under MPL 2.0 (see LICENSE.txt)
  *
  * See README.md for usage and integration instructions.
  */
 
 /*jslint bitwise: false, white: false, browser: true, devel: true */
-/*global Util, window, document */
 
-/* [module]
+"use strict";
- * import Util from "../core/util";
- */
 
-// Globals defined here
+define(['core/util'],
-var WebUtil = {};
+function(Util) {
+    var WebUtil = {};
 
-/*
+    // init log level reading the logging HTTP param
- * ------------------------------------------------------
+    WebUtil.init_logging = function (level) {
- * Namespaced in WebUtil
+        if (typeof level === "undefined") {
- * ------------------------------------------------------
- */
-
-// init log level reading the logging HTTP param
-WebUtil.init_logging = function (level) {
-    "use strict";
-    if (typeof level !== "undefined") {
-        Util._log_level = level;
-    } else {
             var param = document.location.href.match(/logging=([A-Za-z0-9\._\-]*)/);
-        Util._log_level = (param || ['', Util._log_level])[1];
+            if (param !== undefined)
+                level = param;
         }
-    Util.init_logging();
+        Util.init_logging(level);
-};
+    };
 
 
-WebUtil.dirObj = function (obj, depth, parent) {
+    WebUtil.dirObj = function (obj, depth, parent) {
-    "use strict";
         if (! depth) { depth = 2; }
         if (! parent) { parent = ""; }
 
@@ -62,11 +52,10 @@ WebUtil.dirObj = function (obj, depth, parent) {
             }
         }
         return msg;
-};
+    };
 
-// Read a query string variable
+    // Read a query string variable
-WebUtil.getQueryVar = function (name, defVal) {
+    WebUtil.getQueryVar = function (name, defVal) {
-    "use strict";
         var re = new RegExp('.*[?&]' + name + '=([^&#]*)'),
             match = document.location.href.match(re);
         if (typeof defVal === 'undefined') { defVal = null; }
@@ -75,11 +64,10 @@ WebUtil.getQueryVar = function (name, defVal) {
         } else {
             return defVal;
         }
-};
+    };
 
-// Read a hash fragment variable
+    // Read a hash fragment variable
-WebUtil.getHashVar = function (name, defVal) {
+    WebUtil.getHashVar = function (name, defVal) {
-    "use strict";
         var re = new RegExp('.*[&#]' + name + '=([^&]*)'),
             match = document.location.hash.match(re);
         if (typeof defVal === 'undefined') { defVal = null; }
@@ -88,26 +76,24 @@ WebUtil.getHashVar = function (name, defVal) {
         } else {
             return defVal;
         }
-};
+    };
 
-// Read a variable from the fragment or the query string
+    // Read a variable from the fragment or the query string
-// Fragment takes precedence
+    // Fragment takes precedence
-WebUtil.getConfigVar = function (name, defVal) {
+    WebUtil.getConfigVar = function (name, defVal) {
-    "use strict";
         var val = WebUtil.getHashVar(name);
         if (val === null) {
             val = WebUtil.getQueryVar(name, defVal);
         }
         return val;
-};
+    };
 
-/*
+    /*
      * Cookie handling. Dervied from: http://www.quirksmode.org/js/cookies.html
      */
 
-// No days means only for this browser session
+    // No days means only for this browser session
-WebUtil.createCookie = function (name, value, days) {
+    WebUtil.createCookie = function (name, value, days) {
-    "use strict";
         var date, expires;
         if (days) {
             date = new Date();
@@ -124,10 +110,9 @@ WebUtil.createCookie = function (name, value, days) {
             secure = "";
         }
         document.cookie = name + "=" + value + expires + "; path=/" + secure;
-};
+    };
 
-WebUtil.readCookie = function (name, defaultValue) {
+    WebUtil.readCookie = function (name, defaultValue) {
-    "use strict";
         var nameEQ = name + "=",
             ca = document.cookie.split(';');
 
@@ -137,19 +122,17 @@ WebUtil.readCookie = function (name, defaultValue) {
             if (c.indexOf(nameEQ) === 0) { return c.substring(nameEQ.length, c.length); }
         }
         return (typeof defaultValue !== 'undefined') ? defaultValue : null;
-};
+    };
 
-WebUtil.eraseCookie = function (name) {
+    WebUtil.eraseCookie = function (name) {
-    "use strict";
         WebUtil.createCookie(name, "", -1);
-};
+    };
 
-/*
+    /*
      * Setting handling.
      */
 
-WebUtil.initSettings = function (callback /*, ...callbackArgs */) {
+    WebUtil.initSettings = function (callback /*, ...callbackArgs */) {
-    "use strict";
         var callbackArgs = Array.prototype.slice.call(arguments, 1);
         if (window.chrome && window.chrome.storage) {
             window.chrome.storage.sync.get(function (cfg) {
@@ -165,11 +148,10 @@ WebUtil.initSettings = function (callback /*, ...callbackArgs */) {
                 callback.apply(this, callbackArgs);
             }
         }
-};
+    };
 
-// No days means only for this browser session
+    // No days means only for this browser session
-WebUtil.writeSetting = function (name, value) {
+    WebUtil.writeSetting = function (name, value) {
-    "use strict";
         if (window.chrome && window.chrome.storage) {
             //console.log("writeSetting:", name, value);
             if (WebUtil.settings[name] !== value) {
@@ -179,10 +161,9 @@ WebUtil.writeSetting = function (name, value) {
         } else {
             localStorage.setItem(name, value);
         }
-};
+    };
 
-WebUtil.readSetting = function (name, defaultValue) {
+    WebUtil.readSetting = function (name, defaultValue) {
-    "use strict";
         var value;
         if (window.chrome && window.chrome.storage) {
             value = WebUtil.settings[name];
@@ -197,19 +178,18 @@ WebUtil.readSetting = function (name, defaultValue) {
         } else {
             return value;
         }
-};
+    };
 
-WebUtil.eraseSetting = function (name) {
+    WebUtil.eraseSetting = function (name) {
-    "use strict";
         if (window.chrome && window.chrome.storage) {
             window.chrome.storage.sync.remove(name);
             delete WebUtil.settings[name];
         } else {
             localStorage.removeItem(name);
         }
-};
+    };
 
-WebUtil.injectParamIfMissing = function (path, param, value) {
+    WebUtil.injectParamIfMissing = function (path, param, value) {
         // force pretend that we're dealing with a relative path
         // (assume that we wanted an extra if we pass one in)
         path = "/" + path;
@@ -237,29 +217,30 @@ WebUtil.injectParamIfMissing = function (path, param, value) {
         } else {
             return elem.pathname + elem.search + elem.hash;
         }
-};
+    };
 
-// Emulate Element.setCapture() when not supported
+    // Emulate Element.setCapture() when not supported
 
-WebUtil._captureRecursion = false;
+    var _captureElem;
-WebUtil._captureProxy = function (e) {
+    var _captureRecursion = false;
+    var _captureProxy = function (e) {
         // Recursion protection as we'll see our own event
-    if (WebUtil._captureRecursion) return;
+        if (_captureRecursion) return;
 
         // Clone the event as we cannot dispatch an already dispatched event
         var newEv = new e.constructor(e.type, e);
 
-    WebUtil._captureRecursion = true;
+        _captureRecursion = true;
-    WebUtil._captureElem.dispatchEvent(newEv);
+        _captureElem.dispatchEvent(newEv);
-    WebUtil._captureRecursion = false;
+        _captureRecursion = false;
 
         // Implicitly release the capture on button release
         if ((e.type === "mouseup") || (e.type === "touchend")) {
             WebUtil.releaseCapture();
         }
-};
+    };
 
-WebUtil.setCapture = function (elem) {
+    WebUtil.setCapture = function (elem) {
         if (elem.setCapture) {
 
             elem.setCapture();
@@ -294,112 +275,43 @@ WebUtil.setCapture = function (elem) {
                 captureElem.style.display = "none";
                 document.body.appendChild(captureElem);
 
-            captureElem.addEventListener('mousemove', WebUtil._captureProxy);
+                captureElem.addEventListener('mousemove', _captureProxy);
-            captureElem.addEventListener('mouseup', WebUtil._captureProxy);
+                captureElem.addEventListener('mouseup', _captureProxy);
 
-            captureElem.addEventListener('touchmove', WebUtil._captureProxy);
+                captureElem.addEventListener('touchmove', _captureProxy);
-            captureElem.addEventListener('touchend', WebUtil._captureProxy);
+                captureElem.addEventListener('touchend', _captureProxy);
             }
 
-        WebUtil._captureElem = elem;
+            _captureElem = elem;
             captureElem.style.display = null;
 
             // We listen to events on window in order to keep tracking if it
             // happens to leave the viewport
-        window.addEventListener('mousemove', WebUtil._captureProxy);
+            window.addEventListener('mousemove', _captureProxy);
-        window.addEventListener('mouseup', WebUtil._captureProxy);
+            window.addEventListener('mouseup', _captureProxy);
 
-        window.addEventListener('touchmove', WebUtil._captureProxy);
+            window.addEventListener('touchmove', _captureProxy);
-        window.addEventListener('touchend', WebUtil._captureProxy);
+            window.addEventListener('touchend', _captureProxy);
         }
-};
+    };
 
-WebUtil.releaseCapture = function () {
+    WebUtil.releaseCapture = function () {
         if (document.releaseCapture) {
 
             document.releaseCapture();
 
         } else {
             var captureElem = document.getElementById("noVNC_mouse_capture_elem");
-        WebUtil._captureElem = null;
+            _captureElem = null;
             captureElem.style.display = "none";
 
-        window.removeEventListener('mousemove', WebUtil._captureProxy);
+            window.removeEventListener('mousemove', _captureProxy);
-        window.removeEventListener('mouseup', WebUtil._captureProxy);
+            window.removeEventListener('mouseup', _captureProxy);
 
-        window.removeEventListener('touchmove', WebUtil._captureProxy);
+            window.removeEventListener('touchmove', _captureProxy);
-        window.removeEventListener('touchend', WebUtil._captureProxy);
+            window.removeEventListener('touchend', _captureProxy);
-    }
-};
-
-
-// Dynamically load scripts without using document.write()
-// Reference: http://unixpapa.com/js/dyna.html
-//
-// Handles the case where load_scripts is invoked from a script that
-// itself is loaded via load_scripts. Once all scripts are loaded the
-// window.onscriptsloaded handler is called (if set).
-WebUtil.get_include_uri = function (root_dir) {
-    return (typeof INCLUDE_URI !== "undefined") ? INCLUDE_URI + root_dir + '/' : root_dir + '/';
-};
-WebUtil._loading_scripts = [];
-WebUtil._pending_scripts = [];
-WebUtil.load_scripts = function (files_by_dir) {
-    "use strict";
-    var head = document.getElementsByTagName('head')[0], script,
-        ls = WebUtil._loading_scripts, ps = WebUtil._pending_scripts;
-
-    var loadFunc = function (e) {
-        while (ls.length > 0 && (ls[0].readyState === 'loaded' ||
-                                 ls[0].readyState === 'complete')) {
-            // For IE, append the script to trigger execution
-            var s = ls.shift();
-            //console.log("loaded script: " + s.src);
-            head.appendChild(s);
-        }
-        if (!this.readyState ||
-            (Util.Engine.presto && this.readyState === 'loaded') ||
-            this.readyState === 'complete') {
-            if (ps.indexOf(this) >= 0) {
-                this.onload = this.onreadystatechange = null;
-                //console.log("completed script: " + this.src);
-                ps.splice(ps.indexOf(this), 1);
-
-                // Call window.onscriptsload after last script loads
-                if (ps.length === 0 && window.onscriptsload) {
-                    window.onscriptsload();
-                }
-            }
         }
     };
 
-    var root_dirs = Object.keys(files_by_dir);
+    return WebUtil;
-
+});
-    for (var d = 0; d < root_dirs.length; d++) {
-        var root_dir = root_dirs[d];
-        var files = files_by_dir[root_dir];
-
-        for (var f = 0; f < files.length; f++) {
-            script = document.createElement('script');
-            script.type = 'text/javascript';
-            script.src = WebUtil.get_include_uri(root_dir) + files[f];
-            //console.log("loading script: " + script.src);
-            script.onload = script.onreadystatechange = loadFunc;
-            // In-order script execution tricks
-            if (Util.Engine.trident) {
-                // For IE wait until readyState is 'loaded' before
-                // appending it which will trigger execution
-                // http://wiki.whatwg.org/wiki/Dynamic_Script_Execution_Order
-                ls.push(script);
-            } else {
-                // For webkit and firefox set async=false and append now
-                // https://developer.mozilla.org/en-US/docs/HTML/Element/script
-                script.async = false;
-                head.appendChild(script);
-            }
-            ps.push(script);
-        }
-    }
-};
-
-/* [module] export default WebUtil; */

core/base64.js

@@ -5,9 +5,11 @@
 // From: http://hg.mozilla.org/mozilla-central/raw-file/ec10630b1a54/js/src/devtools/jint/sunspider/string-base64.js
 
 /*jslint white: false */
-/*global console */
 
-var Base64 = {
+"use strict";
+
+define(function () {
+    var Base64 = {
         /* Convert data (an array of integers) to a Base64 string. */
         toBase64Table : 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/='.split(''),
         base64Pad     : '=',
@@ -110,6 +112,7 @@ var Base64 = {
 
             return result;
         }
-}; /* End of Base64 namespace */
+    };
 
-/* [module] export default Base64; */
+    return Base64;
+});

core/des.js

@@ -77,9 +77,10 @@
 
 /* jslint white: false */
 
-/* [module] export default */ function DES(passwd) {
+"use strict";
-    "use strict";
 
+define(function () {
+    function DES(passwd) {
         // Tables, permutations, S-boxes, etc.
         // jshint -W013
         var PC2 = [13,16,10,23, 0, 4, 2,27,14, 5,20, 9,22,18,11, 3,
@@ -273,4 +274,7 @@
         setKeys(passwd);             // Setup keys
         return {'encrypt': encrypt}; // Public interface
 
-}; // function DES
+    }; // function DES
+
+    return DES;
+});

core/display.js

@@ -2,20 +2,27 @@
  * noVNC: HTML5 VNC client
  * Copyright (C) 2012 Joel Martin
  * Copyright (C) 2015 Samuel Mannehed for Cendio AB
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
  * Licensed under MPL 2.0 (see LICENSE.txt)
  *
  * See README.md for usage and integration instructions.
  */
 
 /*jslint browser: true, white: false */
-/*global Util, Base64, changeCursor */
 
-/* [module]
+"use strict";
- * import Util from "./util";
- * import Base64 from "./base64";
- */
 
-/* [module] export default */ function Display(defaults) {
+define(["core/util", "core/base64"],
+function (Util, Base64) {
+    var SUPPORTS_IMAGEDATA_CONSTRUCTOR = false;
+    try {
+        new ImageData(new Uint8ClampedArray(4), 1, 1);
+        SUPPORTS_IMAGEDATA_CONSTRUCTOR = true;
+    } catch (ex) {
+        // ignore failure
+    }
+
+    function Display(defaults) {
         this._drawCtx = null;
         this._c_forceCanvas = false;
 
@@ -96,19 +103,7 @@
         }
 
         Util.Debug("<< Display.constructor");
-};
+    };
-
-(function () {
-    "use strict";
-
-    var SUPPORTS_IMAGEDATA_CONSTRUCTOR = false;
-    try {
-        new ImageData(new Uint8ClampedArray(4), 1, 1);
-        SUPPORTS_IMAGEDATA_CONSTRUCTOR = true;
-    } catch (ex) {
-        // ignore failure
-    }
-
 
     Display.prototype = {
         // Public methods
@@ -875,4 +870,6 @@
         var url = 'data:image/x-icon;base64,' + Base64.encode(cur);
         target.style.cursor = 'url(' + url + ')' + hotx + ' ' + hoty + ', default';
     };
-})();
+
+    return { Display: Display };
+});

core/inflator.mod.js

@@ -1,40 +0,0 @@
-var zlib = require('pako/lib/zlib/inflate.js');
-var ZStream = require('pako/lib/zlib/zstream.js');
-
-function Inflate() {
-    this.strm = new ZStream();
-    this.chunkSize = 1024 * 10 * 10;
-    this.strm.output = new Uint8Array(this.chunkSize);
-    this.windowBits = 5;
-
-    zlib.inflateInit(this.strm, this.windowBits);
-};
-
-Inflate.prototype = {
-    inflate: function (data, flush, expected) {
-        this.strm.input = data;
-        this.strm.avail_in = this.strm.input.length;
-        this.strm.next_in = 0;
-        this.strm.next_out = 0;
-
-        // resize our output buffer if it's too small
-        // (we could just use multiple chunks, but that would cause an extra
-        // allocation each time to flatten the chunks)
-        if (expected > this.chunkSize) {
-            this.chunkSize = expected;
-            this.strm.output = new Uint8Array(this.chunkSize);
-        }
-
-        this.strm.avail_out = this.chunkSize;
-
-        zlib.inflate(this.strm, flush);
-
-        return new Uint8Array(this.strm.output.buffer, 0, this.strm.next_out);
-    },
-
-    reset: function () {
-        zlib.inflateReset(this.strm);
-    }
-};
-
-module.exports = { Inflate: Inflate };

core/input/devices.js

@@ -2,27 +2,21 @@
  * noVNC: HTML5 VNC client
  * Copyright (C) 2012 Joel Martin
  * Copyright (C) 2013 Samuel Mannehed for Cendio AB
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
  * Licensed under MPL 2.0 or any later version (see LICENSE.txt)
  */
 
 /*jslint browser: true, white: false */
-/*global window, Util */
 
-/* [module]
+"use strict";
- * import Util from "../util";
- * import KeyboardUtil from "./util";
- */
-
-/* [module] export */ var Keyboard;
-
-(function () {
-    "use strict";
 
+define(["core/util", "core/input/util"],
+function (Util, KeyboardUtil) {
     //
     // Keyboard event handler
     //
 
-    Keyboard = function (defaults) {
+    function Keyboard(defaults) {
         this._keyDownList = [];         // List of depressed keys
                                         // (even if they are happy)
 
@@ -158,12 +152,8 @@
 
         ['onKeyPress', 'rw', 'func'] // Handler for key press/release
     ]);
-})();
 
-/* [module] export */ var Mouse;
+    function Mouse(defaults) {
-
-(function () {
-    Mouse = function (defaults) {
         this._mouseCaptured  = false;
 
         this._doubleClickTimer = null;
@@ -402,4 +392,7 @@
         ['onMouseMove',    'rw', 'func'],  // Handler for mouse movement
         ['touchButton',    'rw', 'int']    // Button mask (1, 2, 4) for touch devices (0 means ignore clicks)
     ]);
-})();
+
+    return { Keyboard: Keyboard,
+             Mouse: Mouse };
+});

core/input/keysym.js

@@ -1,4 +1,7 @@
-var KeyTable = {
+"use strict";
+
+define(function () {
+    var KeyTable = {
         XK_VoidSymbol:                  0xffffff, /* Void symbol */
 
         XK_BackSpace:                   0xff08, /* Back space, back char */
@@ -377,6 +380,7 @@ var KeyTable = {
         XK_yacute:                      0x00fd, /* U+00FD LATIN SMALL LETTER Y WITH ACUTE */
         XK_thorn:                       0x00fe, /* U+00FE LATIN SMALL LETTER THORN */
         XK_ydiaeresis:                  0x00ff, /* U+00FF LATIN SMALL LETTER Y WITH DIAERESIS */
-};
+    };
 
-/* [module] export default KeyTable; */
+    return KeyTable;
+});

core/input/util.js

@@ -1,12 +1,17 @@
-/* [module]
+/*
- * import KeyTable from "./keysym";
+ * noVNC: HTML5 VNC client
- * import keysyms from "./keysymdef";
+ * Copyright (C) 2012 Joel Martin
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
+ * Licensed under MPL 2.0 or any later version (see LICENSE.txt)
  */
 
-var KeyboardUtil = {};
+/*jslint browser: true, white: false */
 
-(function() {
+"use strict";
-    "use strict";
+
+define(["core/input/keysym", "core/input/keysymdef"],
+function (KeyTable, keysyms) {
+    var KeyboardUtil = {};
 
     function substituteCodepoint(cp) {
         // Any Unicode code points which do not have corresponding keysym entries
@@ -286,11 +291,8 @@ var KeyboardUtil = {};
     KeyboardUtil.keysymFromKeyCode = keysymFromKeyCode;
     KeyboardUtil.nonCharacterKey = nonCharacterKey;
     KeyboardUtil.substituteCodepoint = substituteCodepoint;
-})();
-
-KeyboardUtil.QEMUKeyEventDecoder = function(modifierState, next) {
-    "use strict";
 
+    KeyboardUtil.QEMUKeyEventDecoder = function(modifierState, next) {
         function sendAll(evts) {
             for (var i = 0; i < evts.length; ++i) {
                 next(evts[i]);
@@ -356,10 +358,9 @@ KeyboardUtil.QEMUKeyEventDecoder = function(modifierState, next) {
             },
             releaseAll: function() { next({type: 'releaseall'}); }
         };
-};
+    };
 
-KeyboardUtil.TrackQEMUKeyState = function(next) {
+    KeyboardUtil.TrackQEMUKeyState = function(next) {
-    "use strict";
         var state = [];
 
         return function (evt) {
@@ -417,17 +418,16 @@ KeyboardUtil.TrackQEMUKeyState = function(next) {
                 state = [];
             }
         };
-};
+    };
 
-// Takes a DOM keyboard event and:
+    // Takes a DOM keyboard event and:
-// - determines which keysym it represents
+    // - determines which keysym it represents
-// - determines a keyId  identifying the key that was pressed (corresponding to the key/keyCode properties on the DOM event)
+    // - determines a keyId  identifying the key that was pressed (corresponding to the key/keyCode properties on the DOM event)
-// - synthesizes events to synchronize modifier key state between which modifiers are actually down, and which we thought were down
+    // - synthesizes events to synchronize modifier key state between which modifiers are actually down, and which we thought were down
-// - marks each event with an 'escape' property if a modifier was down which should be "escaped"
+    // - marks each event with an 'escape' property if a modifier was down which should be "escaped"
-// - generates a "stall" event in cases where it might be necessary to wait and see if a keypress event follows a keydown
+    // - generates a "stall" event in cases where it might be necessary to wait and see if a keypress event follows a keydown
-// This information is collected into an object which is passed to the next() function. (one call per event)
+    // This information is collected into an object which is passed to the next() function. (one call per event)
-KeyboardUtil.KeyEventDecoder = function(modifierState, next) {
+    KeyboardUtil.KeyEventDecoder = function(modifierState, next) {
-    "use strict";
         function sendAll(evts) {
             for (var i = 0; i < evts.length; ++i) {
                 next(evts[i]);
@@ -505,16 +505,15 @@ KeyboardUtil.KeyEventDecoder = function(modifierState, next) {
             },
             releaseAll: function() { next({type: 'releaseall'}); }
         };
-};
+    };
 
-// Combines keydown and keypress events where necessary to handle char modifiers.
+    // Combines keydown and keypress events where necessary to handle char modifiers.
-// On some OS'es, a char modifier is sometimes used as a shortcut modifier.
+    // On some OS'es, a char modifier is sometimes used as a shortcut modifier.
-// For example, on Windows, AltGr is synonymous with Ctrl-Alt. On a Danish keyboard layout, AltGr-2 yields a @, but Ctrl-Alt-D does nothing
+    // For example, on Windows, AltGr is synonymous with Ctrl-Alt. On a Danish keyboard layout, AltGr-2 yields a @, but Ctrl-Alt-D does nothing
-// so when used with the '2' key, Ctrl-Alt counts as a char modifier (and should be escaped), but when used with 'D', it does not.
+    // so when used with the '2' key, Ctrl-Alt counts as a char modifier (and should be escaped), but when used with 'D', it does not.
-// The only way we can distinguish these cases is to wait and see if a keypress event arrives
+    // The only way we can distinguish these cases is to wait and see if a keypress event arrives
-// When we receive a "stall" event, wait a few ms before processing the next keydown. If a keypress has also arrived, merge the two
+    // When we receive a "stall" event, wait a few ms before processing the next keydown. If a keypress has also arrived, merge the two
-KeyboardUtil.VerifyCharModifier = function(next) {
+    KeyboardUtil.VerifyCharModifier = function(next) {
-    "use strict";
         var queue = [];
         var timer = null;
         function process() {
@@ -563,15 +562,14 @@ KeyboardUtil.VerifyCharModifier = function(next) {
             queue.push(evt);
             process();
         };
-};
+    };
 
-// Keeps track of which keys we (and the server) believe are down
+    // Keeps track of which keys we (and the server) believe are down
-// When a keyup is received, match it against this list, to determine the corresponding keysym(s)
+    // When a keyup is received, match it against this list, to determine the corresponding keysym(s)
-// in some cases, a single key may produce multiple keysyms, so the corresponding keyup event must release all of these chars
+    // in some cases, a single key may produce multiple keysyms, so the corresponding keyup event must release all of these chars
-// key repeat events should be merged into a single entry.
+    // key repeat events should be merged into a single entry.
-// Because we can't always identify which entry a keydown or keyup event corresponds to, we sometimes have to guess
+    // Because we can't always identify which entry a keydown or keyup event corresponds to, we sometimes have to guess
-KeyboardUtil.TrackKeyState = function(next) {
+    KeyboardUtil.TrackKeyState = function(next) {
-    "use strict";
         var state = [];
 
         return function (evt) {
@@ -650,12 +648,11 @@ KeyboardUtil.TrackKeyState = function(next) {
                 state = [];
             }
         };
-};
+    };
 
-// Handles "escaping" of modifiers: if a char modifier is used to produce a keysym (such as AltGr-2 to generate an @),
+    // Handles "escaping" of modifiers: if a char modifier is used to produce a keysym (such as AltGr-2 to generate an @),
-// then the modifier must be "undone" before sending the @, and "redone" afterwards.
+    // then the modifier must be "undone" before sending the @, and "redone" afterwards.
-KeyboardUtil.EscapeModifiers = function(next) {
+    KeyboardUtil.EscapeModifiers = function(next) {
-    "use strict";
         return function(evt) {
             if (evt.type !== 'keydown' || evt.escape === undefined) {
                 next(evt);
@@ -674,6 +671,7 @@ KeyboardUtil.EscapeModifiers = function(next) {
             }
             /* jshint shadow: false */
         };
-};
+    };
 
-/* [module] export default KeyboardUtil; */
+    return KeyboardUtil;
+});

core/input/xtscancodes.js

@@ -1,4 +1,7 @@
-var XtScancode = {
+"use strict";
+
+define(function () {
+    var XtScancode = {
         "Escape": 0x0001,
         "Digit1": 0x0002,
         "Digit2": 0x0003,
@@ -146,6 +149,7 @@ var XtScancode = {
         "LaunchApp1": 0xE06B,
         "LaunchMail": 0xE06C,
         "MediaSelect": 0xE06D,
-};
+    };
 
-/* [module] export default XtScancode */
+    return XtScancode;
+});

core/rfb.js

@@ -2,6 +2,7 @@
  * noVNC: HTML5 VNC client
  * Copyright (C) 2012 Joel Martin
  * Copyright (C) 2016 Samuel Mannehed for Cendio AB
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
  * Licensed under MPL 2.0 (see LICENSE.txt)
  *
  * See README.md for usage and integration instructions.
@@ -10,22 +11,19 @@
  * (c) 2012 Michael Tinglof, Joe Balaz, Les Piech (Mercuri.ca)
  */
 
-/* [module]
- * import Util from "./util";
- * import Display from "./display";
- * import { Keyboard, Mouse } from "./input/devices"
- * import Websock from "./websock"
- * import Base64 from "./base64";
- * import DES from "./des";
- * import KeyTable from "./input/keysym";
- * import XtScancode from "./input/xtscancodes";
- * import Inflator from "./inflator.mod";
- */
 /*jslint white: false, browser: true */
-/*global window, Util, Display, Keyboard, Mouse, Websock, Websock_native, Base64, DES, KeyTable, Inflator, XtScancode */
 
-/* [module] export default */ function RFB(defaults) {
+"use strict";
-    "use strict";
+
+define(["core/util", "core/display", "core/websock",
+        "core/inflator", "core/des",
+        "core/input/devices", "core/input/keysym",
+        "core/input/xtscancodes"],
+function (Util, display, websock, Inflator, DES, devices,
+          KeyTable, XtScancode) {
+    var _ = Util.Localisation.get;
+
+    function RFB(defaults) {
         if (!defaults) {
             defaults = {};
         }
@@ -190,22 +188,22 @@
         // NB: nothing that needs explicit teardown should be done
         // before this point, since this can throw an exception
         try {
-        this._display = new Display({target: this._target,
+            this._display = new display.Display({target: this._target,
                                                   onFlush: this._onFlush.bind(this)});
         } catch (exc) {
             Util.Error("Display exception: " + exc);
             throw exc;
         }
 
-    this._keyboard = new Keyboard({target: this._focusContainer,
+        this._keyboard = new devices.Keyboard({target: this._focusContainer,
                                                onKeyPress: this._handleKeyPress.bind(this)});
 
-    this._mouse = new Mouse({target: this._target,
+        this._mouse = new devices.Mouse({target: this._target,
                                          onMouseButton: this._handleMouseButton.bind(this),
                                          onMouseMove: this._handleMouseMove.bind(this),
                                          notify: this._keyboard.sync.bind(this._keyboard)});
 
-    this._sock = new Websock();
+        this._sock = new websock.Websock();
         this._sock.on('message', this._handle_message.bind(this));
         this._sock.on('open', function () {
             if ((this._rfb_connection_state === 'connecting') &&
@@ -260,10 +258,7 @@
         Util.Info("Using native WebSockets, render mode: " + rmode);
 
         Util.Debug("<< RFB.constructor");
-};
+    };
-
-(function() {
-    var _ = Util.Localisation.get;
 
     RFB.prototype = {
         // Public methods
@@ -2442,4 +2437,6 @@
             Util.Error("Server sent compress level pseudo-encoding");
         }
     };
-})();
+
+    return { RFB: RFB };
+});

core/util.js

@@ -1,33 +1,29 @@
 /*
  * noVNC: HTML5 VNC client
  * Copyright (C) 2012 Joel Martin
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
  * Licensed under MPL 2.0 (see LICENSE.txt)
  *
  * See README.md for usage and integration instructions.
  */
 
 /* jshint white: false, nonstandard: true */
-/*global window, console, document, navigator, ActiveXObject, INCLUDE_URI */
 
-var Util = {};
+"use strict";
 
-/*
+define(function() {
- * ------------------------------------------------------
+    var Util = {};
- * Namespaced in Util
- * ------------------------------------------------------
- */
 
-/*
+    /*
      * Logging/debug routines
      */
 
-Util._log_level = 'warn';
+    var _log_level = 'warn';
-Util.init_logging = function (level) {
+    Util.init_logging = function (level) {
-    "use strict";
         if (typeof level === 'undefined') {
-        level = Util._log_level;
+            level = _log_level;
         } else {
-        Util._log_level = level;
+            _log_level = level;
         }
 
         Util.Debug = Util.Info = Util.Warn = Util.Error = function (msg) {};
@@ -49,15 +45,14 @@ Util.init_logging = function (level) {
             }
             /* jshint +W086 */
         }
-};
+    };
-Util.get_logging = function () {
+    Util.get_logging = function () {
-    return Util._log_level;
+        return _log_level;
-};
+    };
-// Initialize logging level
+    // Initialize logging level
-Util.init_logging();
+    Util.init_logging();
 
-Util.make_property = function (proto, name, mode, type) {
+    Util.make_property = function (proto, name, mode, type) {
-    "use strict";
 
         var getter;
         if (type === 'arr') {
@@ -147,16 +142,15 @@ Util.make_property = function (proto, name, mode, type) {
             setter.call(this, val, idx);
             //delete this['_init_set_' + name];  // remove it after use
         };
-};
+    };
 
-Util.make_properties = function (constructor, arr) {
+    Util.make_properties = function (constructor, arr) {
-    "use strict";
         for (var i = 0; i < arr.length; i++) {
             Util.make_property(constructor.prototype, arr[i][0], arr[i][1], arr[i][2]);
         }
-};
+    };
 
-Util.set_defaults = function (obj, conf, defaults) {
+    Util.set_defaults = function (obj, conf, defaults) {
         var defaults_keys = Object.keys(defaults);
         var conf_keys = Object.keys(conf);
         var keys_obj = {};
@@ -178,42 +172,39 @@ Util.set_defaults = function (obj, conf, defaults) {
                 setter.call(obj, defaults[keys[i]]);
             }
         }
-};
+    };
 
-/*
+    /*
      * Decode from UTF-8
      */
-Util.decodeUTF8 = function (utf8string) {
+    Util.decodeUTF8 = function (utf8string) {
-    "use strict";
         return decodeURIComponent(escape(utf8string));
-};
+    };
 
 
 
-/*
+    /*
      * Cross-browser routines
      */
 
-Util.getPosition = function(obj) {
+    Util.getPosition = function(obj) {
-    "use strict";
         // NB(sross): the Mozilla developer reference seems to indicate that
         // getBoundingClientRect includes border and padding, so the canvas
         // style should NOT include either.
         var objPosition = obj.getBoundingClientRect();
         return {'x': objPosition.left + window.pageXOffset, 'y': objPosition.top + window.pageYOffset,
                 'width': objPosition.width, 'height': objPosition.height};
-};
+    };
 
-Util.getPointerEvent = function (e) {
+    Util.getPointerEvent = function (e) {
         var evt;
         evt = (e ? e : window.event);
         evt = (evt.changedTouches ? evt.changedTouches[0] : evt.touches ? evt.touches[0] : evt);
         return evt;
-};
+    };
 
-// Get mouse event position in DOM element
+    // Get mouse event position in DOM element
-Util.getEventPosition = function (e, obj, scale) {
+    Util.getEventPosition = function (e, obj, scale) {
-    "use strict";
         var evt, docX, docY, pos;
         evt = Util.getPointerEvent(e);
         if (evt.pageX || evt.pageY) {
@@ -234,54 +225,52 @@ Util.getEventPosition = function (e, obj, scale) {
         var x = Math.max(Math.min(realx, pos.width - 1), 0);
         var y = Math.max(Math.min(realy, pos.height - 1), 0);
         return {'x': x / scale, 'y': y / scale, 'realx': realx / scale, 'realy': realy / scale};
-};
+    };
 
-Util.stopEvent = function (e) {
+    Util.stopEvent = function (e) {
         e.stopPropagation();
         e.preventDefault();
-};
+    };
 
-// Touch detection
+    // Touch detection
-Util.isTouchDevice = ('ontouchstart' in document.documentElement) ||
+    Util.isTouchDevice = ('ontouchstart' in document.documentElement) ||
                          // requried for Chrome debugger
                          (document.ontouchstart !== undefined) ||
                          // required for MS Surface
                          (navigator.maxTouchPoints > 0) ||
                          (navigator.msMaxTouchPoints > 0);
-window.addEventListener('touchstart', function onFirstTouch() {
+    window.addEventListener('touchstart', function onFirstTouch() {
         Util.isTouchDevice = true;
         window.removeEventListener('touchstart', onFirstTouch, false);
-}, false);
+    }, false);
 
-Util._cursor_uris_supported = null;
+    var _cursor_uris_supported = null;
 
-Util.browserSupportsCursorURIs = function () {
+    Util.browserSupportsCursorURIs = function () {
-    if (Util._cursor_uris_supported === null) {
+        if (_cursor_uris_supported === null) {
             try {
                 var target = document.createElement('canvas');
                 target.style.cursor = 'url("data:image/x-icon;base64,AAACAAEACAgAAAIAAgA4AQAAFgAAACgAAAAIAAAAEAAAAAEAIAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAD/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////AAAAAAAAAAAAAAAAAAAAAA==") 2 2, default';
 
                 if (target.style.cursor) {
                     Util.Info("Data URI scheme cursor supported");
-                Util._cursor_uris_supported = true;
+                    _cursor_uris_supported = true;
                 } else {
                     Util.Warn("Data URI scheme cursor not supported");
-                Util._cursor_uris_supported = false;
+                    _cursor_uris_supported = false;
                 }
             } catch (exc) {
                 Util.Error("Data URI scheme cursor test exception: " + exc);
-            Util._cursor_uris_supported = false;
+                _cursor_uris_supported = false;
             }
         }
 
-    return Util._cursor_uris_supported;
+        return _cursor_uris_supported;
-};
+    };
 
-// Set browser engine versions. Based on mootools.
+    // Set browser engine versions. Based on mootools.
-Util.Features = {xpath: !!(document.evaluate), air: !!(window.runtime), query: !!(document.querySelector)};
+    Util.Features = {xpath: !!(document.evaluate), air: !!(window.runtime), query: !!(document.querySelector)};
 
-(function () {
-    "use strict";
     // 'presto': (function () { return (!window.opera) ? false : true; }()),
     var detectPresto = function () {
         return !!window.opera;
@@ -348,10 +337,8 @@ Util.Features = {xpath: !!(document.evaluate), air: !!(window.runtime), query: !
         // Extract actual webkit version if available
         Util.Engine.webkit = detectActualWebkit(Util.Engine.webkit);
     }
-})();
 
-Util.Flash = (function () {
+    Util.Flash = (function () {
-    "use strict";
         var v, version;
         try {
             v = navigator.plugins['Shockwave Flash'].description;
@@ -364,15 +351,44 @@ Util.Flash = (function () {
         }
         version = v.match(/\d+/g);
         return {version: parseInt(version[0] || 0 + '.' + version[1], 10) || 0, build: parseInt(version[2], 10) || 0};
-}());
+    }());
 
 
-Util.Localisation = {
+    Util.Localisation = {
         // Currently configured language
         language: 'en',
 
-    // Configure suitable language based on user preferences
+        // Translation data
-    setup: function (supportedLanguages) {
+        _translations: null,
+
+        // Configure and load suitable language based on user preferences
+        setup: function (supportedLanguages, basedir, callback) {
+            Util.Localisation._setLanguageCode(supportedLanguages);
+
+            if (Util.Localisation.language === 'en') {
+                if (callback !== undefined) {
+                    callback();
+                }
+
+                return;
+            }
+
+            if (basedir[basedir.length - 1] !== '/') {
+                basedir = basedir + '/';
+            }
+
+            require([basedir + Util.Localisation.language],
+            function(lang) {
+                Util.Localisation._translations = lang;
+
+                if (callback !== undefined) {
+                    callback();
+                }
+            });
+        },
+
+        // Internal function to figure out the proper language code
+        _setLanguageCode: function (supportedLanguages) {
             var userLanguages;
 
             Util.Localisation.language = 'en'; // Default: US English
@@ -435,11 +451,12 @@ Util.Localisation = {
 
         // Retrieve localised text
         get: function (id) {
-        if (typeof Language !== 'undefined' && Language[id]) {
+            if ((Util.Localisation._translations === null) ||
-            return Language[id];
+                (Util.Localisation._translations[id] === undefined)) {
-        } else {
                 return id;
             }
+
+            return Util.Localisation._translations[id];
         },
 
         // Traverses the DOM and translates relevant fields
@@ -504,7 +521,7 @@ Util.Localisation = {
                 }
 
                 for (var i = 0;i < elem.childNodes.length;i++) {
-                node = elem.childNodes[i];
+                    var node = elem.childNodes[i];
                     if (node.nodeType === node.ELEMENT_NODE) {
                         process(node, enabled);
                     } else if (node.nodeType === node.TEXT_NODE && enabled) {
@@ -515,6 +532,7 @@ Util.Localisation = {
 
             process(document.body, true);
         },
-};
+    };
 
-/* [module] export default Util; */
+    return Util;
+});

core/websock.js

@@ -14,17 +14,14 @@
  * read binary data off of the receive queue.
  */
 
-/* [module]
- * import Util from "./util";
- * import Base64 from "./base64";
- */
-
 /*jslint browser: true, bitwise: true */
-/*global Util*/
 
-/* [module] export default */ function Websock() {
+"use strict";
-    "use strict";
 
+define(["core/util"],
+function (Util) {
+
+    function Websock() {
         this._websocket = null;  // WebSocket object
 
         this._rQi = 0;           // Receive queue index
@@ -48,10 +45,8 @@
             'close': function () {},
             'error': function () {}
         };
-};
+    };
 
-(function () {
-    "use strict";
     // this has performance issues in some versions Chromium, and
     // doesn't gain a tremendous amount of performance increase in Firefox
     // at the moment.  It may be valuable to turn it on in the future.
@@ -423,4 +418,6 @@
             }
         }
     };
-})();
+
+    return { Websock: Websock };
+});

docs/notes

@@ -1,5 +1,5 @@
 Rebuilding inflator.js
 
 - Download pako from npm
-- Install browserify using npm
+- Install requirejs using npm
-- browserify core/inflator.mod.js -o core/inflator.js -s Inflator
+- make -C inflator install

inflator/Makefile

@@ -0,0 +1,19 @@
+.PHONY: all install clean
+
+all: inflator-merged.js
+
+RJS := r.js
+
+inflator-merged.js: build.js inflator.js pako
+	r.js -o build.js
+
+pako: ../node_modules/pako
+	$(RJS) -convert $< pako/
+
+install: all
+	rm -f ../core/inflator.js
+	cp inflator-merged.js ../core/inflator.js
+
+clean:
+	rm -f inflator.js
+	rm -rf pako

inflator/build.js

@@ -0,0 +1,8 @@
+({
+    baseUrl: ".",
+    name: "core/inflator",
+    paths: {
+        "core": ".",
+    },
+    out: "inflator-merged.js"
+})

inflator/inflator.js

@@ -0,0 +1,52 @@
+/*
+ * noVNC: HTML5 VNC client
+ * Copyright (C) 2012 Joel Martin
+ * Copyright (C) 2017 Pierre Ossman for Cendio AB
+ * Licensed under MPL 2.0 or any later version (see LICENSE.txt)
+ */
+
+/*jslint browser: true, white: false */
+
+"use strict";
+
+define(["pako/lib/zlib/inflate.js", "pako/lib/zlib/zstream.js"],
+function (zlib, ZStream) {
+
+    function Inflate() {
+        this.strm = new ZStream();
+        this.chunkSize = 1024 * 10 * 10;
+        this.strm.output = new Uint8Array(this.chunkSize);
+        this.windowBits = 5;
+
+        zlib.inflateInit(this.strm, this.windowBits);
+    };
+
+    Inflate.prototype = {
+        inflate: function (data, flush, expected) {
+            this.strm.input = data;
+            this.strm.avail_in = this.strm.input.length;
+            this.strm.next_in = 0;
+            this.strm.next_out = 0;
+
+            // resize our output buffer if it's too small
+            // (we could just use multiple chunks, but that would cause an extra
+            // allocation each time to flatten the chunks)
+            if (expected > this.chunkSize) {
+                this.chunkSize = expected;
+                this.strm.output = new Uint8Array(this.chunkSize);
+            }
+
+            this.strm.avail_out = this.chunkSize;
+
+            zlib.inflate(this.strm, flush);
+
+            return new Uint8Array(this.strm.output.buffer, 0, this.strm.next_out);
+        },
+
+        reset: function () {
+            zlib.inflateReset(this.strm);
+        }
+    };
+
+    return { Inflate: Inflate };
+});

karma.conf.js

@@ -108,34 +108,15 @@ module.exports = function(config) {
 
     // list of files / patterns to load in the browser (loaded in order)
     files: [
-      'tests/fake.*.js',
+      'node_modules/requirejs/require.js',
+      'tests/test-main.js',
       'tests/assertions.js',
-      'core/util.js',  // load first to avoid issues, since methods are called immediately
+      'tests/test.*.js',
-      //'../core/*.js',
+      // Only packaged, not included in browser as RequireJS will
-      'core/base64.js',
+      // do the actual loading
-      'core/input/keysym.js',
+      {pattern: 'tests/fake.*.js', included: false},
-      'core/input/keysymdef.js',
+      {pattern: 'core/*.js', included: false},
-      'core/input/xtscancodes.js',
+      {pattern: 'core/input/*.js', included: false},
-      'core/input/util.js',
-      'core/input/devices.js',
-      'core/websock.js',
-      'core/rfb.js',
-      'core/des.js',
-      'core/display.js',
-      'core/inflator.js',
-      'tests/test.*.js'
-    ],
-
-    client: {
-      mocha: {
-        'ui': 'bdd'
-      }
-    },
-
-    // list of files to exclude
-    exclude: [
-      '../tests/playback.js',
-      '../app/ui.js'
     ],
 
     customLaunchers: customLaunchers,

package.json

@@ -51,6 +51,7 @@
     "open": "^0.0.5",
     "phantomjs-prebuilt": "^2.1.13",
     "po2json": "*",
+    "requirejs": "*",
     "sinon": "^1.17.6",
     "sinon-chai": "^2.8.0",
     "spooky": "^0.2.5",

po/po2js

@@ -40,7 +40,10 @@ var output =
 " * DO NOT EDIT!\n" +
 " */\n" +
 "\n" +
-"Language = {\n";
+"\"use strict\";\n" +
+"\n" +
+"define(function() {\n" +
+"return {\n";
 
 for (msgid in data) {
   if (msgid === "")
@@ -52,5 +55,6 @@ for (msgid in data) {
 }
 
 output += "};\n";
+output += "});\n";
 
 fs.writeFileSync(opt.argv[1], output);

tests/fake.websocket.js

@@ -1,6 +1,6 @@
-var FakeWebSocket;
+"use strict";
 
-(function () {
+define(function () {
     // PhantomJS can't create Event objects directly, so we need to use this
     function make_event(name, props) {
         var evt = document.createEvent('Event');
@@ -13,6 +13,8 @@ var FakeWebSocket;
         return evt;
     }
 
+    var FakeWebSocket;
+
     FakeWebSocket = function (uri, protocols) {
         this.url = uri;
         this.binaryType = "arraybuffer";
@@ -75,7 +77,7 @@ var FakeWebSocket;
 
     FakeWebSocket.__is_fake = true;
 
-    FakeWebSocket.replace = function () {
+    function replace () {
         if (!WebSocket.__is_fake) {
             var real_version = WebSocket;
             WebSocket = FakeWebSocket;
@@ -83,9 +85,11 @@ var FakeWebSocket;
         }
     };
 
-    FakeWebSocket.restore = function () {
+    function restore () {
         if (WebSocket.__is_fake) {
             WebSocket = WebSocket.__real_version;
         }
     };
-})();
+
+    return { replace: replace, restore: restore };
+});

tests/run_from_console.js

@@ -54,59 +54,32 @@ var get_path_cwd = function (/* arguments */) {
   }
 };
 
-if (all_js && !program.autoInject) {
+var temp = require('temp');
-  var all_modules = {};
+temp.track();
 
-  // uses the first instance of the string 'requires local modules: '
+var template = {
-  program.tests.forEach(function (testname) {
-    var full_path = path.resolve(process.cwd(), testname);
-    var content = fs.readFileSync(full_path).toString();
-    var ind = content.indexOf('requires local modules: ');
-    if (ind > -1) {
-      ind += 'requires local modules: '.length;
-      var eol = content.indexOf('\n', ind);
-      var modules = content.slice(ind, eol).split(/,\s*/);
-      modules.forEach(function (mod) {
-        all_modules[get_path('core/', mod) + '.js'] = 1;
-      });
-    }
-
-    var fakes_ind = content.indexOf('requires test modules: ');
-    if (fakes_ind > -1) {
-      fakes_ind += 'requires test modules: '.length;
-      var fakes_eol = content.indexOf('\n', fakes_ind);
-      var fakes_modules = content.slice(fakes_ind, fakes_eol).split(/,\s*/);
-      fakes_modules.forEach(function (mod) {
-        all_modules[get_path('tests/', mod) + '.js'] = 1;
-      });
-    }
-  });
-
-  program.autoInject = Object.keys(all_modules);
-}
-
-if (program.autoInject) {
-  var temp = require('temp');
-  temp.track();
-
-  var template = {
   header: "<html>\n<head>\n<meta charset='utf-8' />\n<link rel='stylesheet' href='" + get_path('node_modules/mocha/mocha.css') + "'/>\n</head>\n<body><div id='mocha'></div>",
   script_tag: function(p) { return "<script src='" + p + "'></script>"; },
   footer: "<script>\nmocha.checkLeaks();\nmocha.globals(['navigator', 'create', 'ClientUtils', '__utils__', 'requestAnimationFrame', 'WebSocket']);\nmocha.run(function () { window.__mocha_done = true; });\n</script>\n</body>\n</html>"
-  };
+};
 
-  template.header += "\n" + template.script_tag(get_path('node_modules/chai/chai.js'));
+template.header += "\n" + template.script_tag(get_path('node_modules/chai/chai.js'));
-  template.header += "\n" + template.script_tag(get_path('node_modules/mocha/mocha.js'));
+template.header += "\n" + template.script_tag(get_path('node_modules/mocha/mocha.js'));
-  template.header += "\n" + template.script_tag(get_path('node_modules/sinon/pkg/sinon.js'));
+template.header += "\n" + template.script_tag(get_path('node_modules/sinon/pkg/sinon.js'));
-  template.header += "\n" + template.script_tag(get_path('node_modules/sinon-chai/lib/sinon-chai.js'));
+template.header += "\n" + template.script_tag(get_path('node_modules/sinon-chai/lib/sinon-chai.js'));
-  template.header += "\n<script>mocha.setup('bdd');</script>";
+template.header += "\n" + template.script_tag(get_path('node_modules/requirejs/require.js'));
+template.header += "\n<script>requirejs.config({ baseUrl: \"" + get_path('.') + "\" });</script>";
+template.header += "\n<script>mocha.setup('bdd');</script>";
 
+template.header += "\n" + template.script_tag(get_path('tests/assertions.js'));
 
+if (program.autoInject) {
   template.header = program.autoInject.reduce(function(acc, sn) {
     return acc + "\n" + template.script_tag(get_path_cwd(sn));
   }, template.header);
+}
 
-  file_paths = program.tests.map(function(jsn, ind) {
+file_paths = program.tests.map(function(jsn, ind) {
   var templ = template.header;
   templ += "\n";
   templ += template.script_tag(get_path_cwd(jsn));
@@ -116,14 +89,7 @@ if (program.autoInject) {
   fs.writeSync(tempfile.fd, templ);
   fs.closeSync(tempfile.fd);
   return tempfile.path;
-  });
+});
-
-}
-else {
-  file_paths = program.tests.map(function(fn) {
-    return path.resolve(process.cwd(), fn);
-  });
-}
 
 var use_ansi = false;
 if (program.color) use_ansi = true;

tests/test-main.js

@@ -0,0 +1,5 @@
+requirejs.config({
+  // Karma serves files under /base
+  baseUrl: '/base'
+});
+

tests/test.base64.js

@@ -1,10 +1,19 @@
-// requires local modules: base64
 var assert = chai.assert;
 var expect = chai.expect;
 
-describe('Base64 Tools', function() {
+describe('Base64 Tools', function(done) {
     "use strict";
 
+    var Base64;
+
+    before(function (done) {
+        requirejs(["core/base64"],
+        function (b) {
+            Base64 = b;
+            done();
+        });
+    });
+
     var BIN_ARR = new Array(256);
     for (var i = 0; i < 256; i++) {
         BIN_ARR[i] = i;

tests/test.display.js

@@ -1,9 +1,21 @@
-// requires local modules: util, base64, display
-// requires test modules: assertions
 /* jshint expr: true */
 var expect = chai.expect;
 
 describe('Display/Canvas Helper', function () {
+    "use strict";
+
+    var Util, Base64, Display;
+
+    before(function (done) {
+        requirejs(["core/util", "core/base64", "core/display"],
+        function (u, b, d) {
+            Util = u;
+            Base64 = b;
+            Display = d.Display;
+            done();
+        });
+    });
+
     var checked_data = [
         0x00, 0x00, 0xff, 255, 0x00, 0x00, 0xff, 255, 0x00, 0xff, 0x00, 255, 0x00, 0xff, 0x00, 255,
         0x00, 0x00, 0xff, 255, 0x00, 0x00, 0xff, 255, 0x00, 0xff, 0x00, 255, 0x00, 0xff, 0x00, 255,

tests/test.helper.js

@@ -1,10 +1,20 @@
-// requires local modules: input/keysym, input/keysymdef, input/util
-
 var assert = chai.assert;
 var expect = chai.expect;
 
 describe('Helpers', function() {
     "use strict";
+
+    var keysyms, KeyboardUtil;
+
+    before(function (done) {
+        requirejs(["core/input/keysymdef", "core/input/util"],
+        function (k, u) {
+            keysyms = k;
+            KeyboardUtil = u;
+            done();
+        });
+    });
+
     describe('keysymFromKeyCode', function() {
         it('should map known keycodes to keysyms', function() {
             expect(KeyboardUtil.keysymFromKeyCode(0x41, false), 'a').to.be.equal(0x61);
@@ -101,8 +111,13 @@ describe('Helpers', function() {
     });
 
     describe('Modifier Sync', function() { // return a list of fake events necessary to fix modifier state
+        var sync;
+
+        beforeEach(function() {
+            sync = KeyboardUtil.ModifierSync();
+        });
+
         describe('Toggle all modifiers', function() {
-            var sync = KeyboardUtil.ModifierSync();
             it ('should do nothing if all modifiers are up as expected', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
@@ -134,6 +149,14 @@ describe('Helpers', function() {
                 expect(keysyms[0xffe7]);
             });
             it ('should do nothing if all modifiers are down as expected', function() {
+                sync.keydown({
+                    keyCode: 0x41,
+                    ctrlKey: true,
+                    altKey: true,
+                    altGraphKey: true,
+                    shiftKey: true,
+                    metaKey: true
+                });
                 expect(sync.keydown({
                     keyCode: 0x41,
                     ctrlKey: true,
@@ -145,7 +168,6 @@ describe('Helpers', function() {
             });
         });
         describe('Toggle Ctrl', function() {
-            var sync = KeyboardUtil.ModifierSync();
             it('should sync if modifier is suddenly down', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
@@ -153,6 +175,10 @@ describe('Helpers', function() {
                 })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe3), type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
+                sync.keydown({
+                    keyCode: 0x41,
+                    ctrlKey: true,
+                });
                 expect(sync.keydown({
                     keyCode: 0x41,
                     ctrlKey: false
@@ -160,7 +186,6 @@ describe('Helpers', function() {
             });
         });
         describe('Toggle Alt', function() {
-            var sync = KeyboardUtil.ModifierSync();
             it('should sync if modifier is suddenly down', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
@@ -168,6 +193,10 @@ describe('Helpers', function() {
                 })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe9), type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
+                sync.keydown({
+                    altKey: 0x41,
+                    ctrlKey: true,
+                });
                 expect(sync.keydown({
                     keyCode: 0x41,
                     altKey: false
@@ -175,7 +204,6 @@ describe('Helpers', function() {
             });
         });
         describe('Toggle AltGr', function() {
-            var sync = KeyboardUtil.ModifierSync();
             it('should sync if modifier is suddenly down', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
@@ -183,6 +211,10 @@ describe('Helpers', function() {
                 })).to.be.deep.equal([{keysym: keysyms.lookup(0xfe03), type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
+                sync.keydown({
+                    keyCode: 0x41,
+                    altGraphKey: true,
+                });
                 expect(sync.keydown({
                     keyCode: 0x41,
                     altGraphKey: false
@@ -190,7 +222,6 @@ describe('Helpers', function() {
             });
         });
         describe('Toggle Shift', function() {
-            var sync = KeyboardUtil.ModifierSync();
             it('should sync if modifier is suddenly down', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
@@ -198,6 +229,10 @@ describe('Helpers', function() {
                 })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe1), type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
+                sync.keydown({
+                    keyCode: 0x41,
+                    shiftKey: true,
+                });
                 expect(sync.keydown({
                     keyCode: 0x41,
                     shiftKey: false
@@ -205,7 +240,6 @@ describe('Helpers', function() {
             });
         });
         describe('Toggle Meta', function() {
-            var sync = KeyboardUtil.ModifierSync();
             it('should sync if modifier is suddenly down', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
@@ -213,6 +247,10 @@ describe('Helpers', function() {
                 })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe7), type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
+                sync.keydown({
+                    keyCode: 0x41,
+                    metaKey: true,
+                });
                 expect(sync.keydown({
                     keyCode: 0x41,
                     metaKey: false
@@ -231,7 +269,6 @@ describe('Helpers', function() {
                 }), 'B').to.be.deep.equal([]);
             })
             it('should update state on modifier keyevents', function() {
-                var sync = KeyboardUtil.ModifierSync();
                 sync.keydown({
                     keyCode: 0x11,
                 });

tests/test.keyboard.js

@@ -1,10 +1,21 @@
-// requires local modules: input/devices, input/util, input/keysymdef, input/keysym
 var assert = chai.assert;
 var expect = chai.expect;
 
 /* jshint newcap: false, expr: true */
 describe('Key Event Pipeline Stages', function() {
     "use strict";
+
+    var keysyms, KeyboardUtil;
+
+    before(function (done) {
+        requirejs(["core/input/keysymdef", "core/input/util"],
+        function (k, u) {
+            keysyms = k;
+            KeyboardUtil = u;
+            done();
+        });
+    });
+
     describe('Decode Keyboard Events', function() {
         it('should pass events to the next stage', function(done) {
             KeyboardUtil.KeyEventDecoder(KeyboardUtil.ModifierSync(), function(evt) {

tests/test.rfb.js

@@ -1,9 +1,10 @@
-// requires local modules: util, websock, rfb, input/util, input/keysym, input/keysymdef, input/devices, inflator, des, display
+// requires test modules: assertions
-// requires test modules: fake.websocket, assertions
 /* jshint expr: true */
 var assert = chai.assert;
 var expect = chai.expect;
 
+var RFB;
+
 function make_rfb (extra_opts) {
     if (!extra_opts) {
         extra_opts = {};
@@ -34,8 +35,23 @@ var push32 = function (arr, num) {
 
 describe('Remote Frame Buffer Protocol Client', function() {
     "use strict";
-    before(FakeWebSocket.replace);
+
-    after(FakeWebSocket.restore);
+    var Websock, FakeWebSocket;
+
+    before(function (done) {
+        requirejs(["core/rfb", "core/websock", "tests/fake.websocket"],
+        function (r, w, f) {
+            RFB = r.RFB;
+            Websock = w.Websock;
+            FakeWebSocket = f;
+            FakeWebSocket.replace();
+            done();
+        });
+    });
+
+    after(function () {
+        FakeWebSocket.restore();
+    });
 
     before(function () {
         this.clock = sinon.useFakeTimers();

tests/test.util.js

@@ -1,4 +1,3 @@
-// requires local modules: util
 /* jshint expr: true */
 
 var assert = chai.assert;
@@ -7,6 +6,16 @@ var expect = chai.expect;
 describe('Utils', function() {
     "use strict";
 
+    var Util;
+
+    before(function (done) {
+        requirejs(["core/util"],
+        function (u) {
+            Util = u;
+            done();
+        });
+    });
+
     describe('logging functions', function () {
         beforeEach(function () {
             sinon.spy(console, 'log');
@@ -57,7 +66,7 @@ describe('Utils', function() {
     });
 
     describe('language selection', function () {
-        var origNavigator;
+        var origNavigator, origRequire;
         beforeEach(function () {
             // window.navigator is a protected read-only property in many
             // environments, so we need to redefine it whilst running these
@@ -77,8 +86,13 @@ describe('Utils', function() {
             }
 
             window.navigator.languages = [];
+
+            // Prevent the code from trying to actually load translations
+            origRequire = require;
+            require = function (mods, func) { func([]); };
         });
         afterEach(function () {
+            require = origRequire;
             Object.defineProperty(window, "navigator", origNavigator);
         });
 
@@ -87,37 +101,37 @@ describe('Utils', function() {
         });
         it('should use English if no user language matches', function() {
             window.navigator.languages = ["nl", "de"];
-            Util.Localisation.setup(["es", "fr"]);
+            Util.Localisation.setup(["es", "fr"], ".");
             expect(Util.Localisation.language).to.equal('en');
         });
         it('should use the most preferred user language', function() {
             window.navigator.languages = ["nl", "de", "fr"];
-            Util.Localisation.setup(["es", "fr", "de"]);
+            Util.Localisation.setup(["es", "fr", "de"], ".");
             expect(Util.Localisation.language).to.equal('de');
         });
         it('should prefer sub-languages languages', function() {
             window.navigator.languages = ["pt-BR"];
-            Util.Localisation.setup(["pt", "pt-BR"]);
+            Util.Localisation.setup(["pt", "pt-BR"], ".");
             expect(Util.Localisation.language).to.equal('pt-BR');
         });
         it('should fall back to language "parents"', function() {
             window.navigator.languages = ["pt-BR"];
-            Util.Localisation.setup(["fr", "pt", "de"]);
+            Util.Localisation.setup(["fr", "pt", "de"], ".");
             expect(Util.Localisation.language).to.equal('pt');
         });
         it('should not use specific language when user asks for a generic language', function() {
             window.navigator.languages = ["pt", "de"];
-            Util.Localisation.setup(["fr", "pt-BR", "de"]);
+            Util.Localisation.setup(["fr", "pt-BR", "de"], ".");
             expect(Util.Localisation.language).to.equal('de');
         });
         it('should handle underscore as a separator', function() {
             window.navigator.languages = ["pt-BR"];
-            Util.Localisation.setup(["pt_BR"]);
+            Util.Localisation.setup(["pt_BR"], ".");
             expect(Util.Localisation.language).to.equal('pt_BR');
         });
         it('should handle difference in case', function() {
             window.navigator.languages = ["pt-br"];
-            Util.Localisation.setup(["pt-BR"]);
+            Util.Localisation.setup(["pt-BR"], ".");
             expect(Util.Localisation.language).to.equal('pt-BR');
         });
     });

tests/test.websock.js

@@ -1,5 +1,3 @@
-// requires local modules: websock, util
-// requires test modules: fake.websocket, assertions
 /* jshint expr: true */
 var assert = chai.assert;
 var expect = chai.expect;
@@ -7,6 +5,17 @@ var expect = chai.expect;
 describe('Websock', function() {
     "use strict";
 
+    var Websock, FakeWebSocket;
+
+    before(function (done) {
+        requirejs(["core/websock", "tests/fake.websocket"],
+        function (w, f) {
+            Websock = w.Websock;
+            FakeWebSocket = f;
+            done();
+        });
+    });
+
     describe('Queue methods', function () {
         var sock;
         var RQ_TEMPLATE = new Uint8Array([0, 1, 2, 3, 4, 5, 6, 7]);

utils/parse.js

@@ -80,12 +80,15 @@ var out = "// This file describes mappings from Unicode codepoints to the keysym
 "// (and optionally, key names) expected by the RFB protocol\n" +
 "// How this file was generated:\n" +
 "// " + process.argv.join(" ") + "\n" +
-"var keysyms = (function(){\n" +
+"\n" +
-"    \"use strict\";\n" +
+"\"use strict\";\n" +
+"\n" +
+"define(function () {\n" +
 "    var keynames = {keysyms};\n" +
 "    var codepoints = {codepoints};\n" +
 "\n" +
 "    function lookup(k) { return k ? {keysym: k, keyname: keynames ? keynames[k] : k} : undefined; }\n" +
+"\n" +
 "    return {\n" +
 "        fromUnicode : function(u) {\n" +
 "            var keysym = codepoints[u];\n" +
@@ -96,7 +99,7 @@ var out = "// This file describes mappings from Unicode codepoints to the keysym
 "        },\n" +
 "        lookup : lookup\n" +
 "    };\n" +
-"})();\n";
+"});\n";
 out = out.replace('{keysyms}', use_keynames ? JSON.stringify(keysyms) : "null");
 out = out.replace('{codepoints}', JSON.stringify(codepoints));
 

vnc.html

@@ -55,10 +55,7 @@
     <!-- Stylesheets -->
     <link rel="stylesheet" href="app/styles/base.css" />
 
-    <!--
+    <script type='text/javascript' data-main='app/novnc.js' src='app/require.js'></script>
-    <script type='text/javascript'
-        src='http://getfirebug.com/releases/lite/1.2/firebug-lite-compressed.js'></script>
-    -->
 
 </head>
 
@@ -325,12 +322,5 @@
         <source src="app/sounds/bell.oga" type="audio/ogg">
         <source src="app/sounds/bell.mp3" type="audio/mpeg">
     </audio>
-
-    <!-- begin scripts -->
-    <script src="core/util.js"></script>
-    <script src="app/webutil.js"></script>
-    <script src="app/ui.js"></script>
-    <!-- end scripts -->
-
  </body>
 </html>

vnc_auto.html

@@ -38,12 +38,7 @@
     <!-- Stylesheets -->
     <link rel="stylesheet" href="app/styles/auto.css">
 
-     <!--
+    <script src="app/require.js"></script>
-    <script type='text/javascript'
-        src='http://getfirebug.com/releases/lite/1.2/firebug-lite-compressed.js'></script>
-    -->
-        <script src="core/util.js"></script>
-        <script src="app/webutil.js"></script>
 </head>
 
 <body style="margin: 0px;">
@@ -74,14 +69,10 @@
 
         <script>
         /*jslint white: false */
-        /*global window, $, Util, RFB, */
         "use strict";
 
-        // Load supporting scripts
+        require(["app/webutil", "core/rfb"],
-        WebUtil.load_scripts({
+        function(WebUtil, rfbmod) {
-            'core': ["base64.js", "websock.js", "des.js", "input/keysymdef.js",
-                     "input/xtscancodes.js", "input/util.js", "input/devices.js",
-                     "display.js", "inflator.js", "rfb.js", "input/keysym.js"]});
 
             var rfb;
             var resizeTimeout;
@@ -215,7 +206,6 @@
                 }
             }
 
-        window.onscriptsload = function () {
             var host, port, password, path, token;
 
             document.getElementById('sendCtrlAltDelButton').style.display = "inline";
@@ -261,7 +251,7 @@
             }
 
             try {
-                rfb = new RFB({'target':       document.getElementById('noVNC_canvas'),
+                rfb = new rfbmod.RFB({'target':       document.getElementById('noVNC_canvas'),
                                       'encrypt':      WebUtil.getConfigVar('encrypt',
                                                 (window.location.protocol === "https:")),
                                       'repeaterID':   WebUtil.getConfigVar('repeaterID', ''),
@@ -282,7 +272,7 @@
             }
 
             rfb.connect(host, port, password, path);
-        };
+        });
         </script>
 
     </body>