crabapples
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Addressed the review comments

This commit is contained in:
Ankit kumar yadav 2026-05-03 22:53:33 +05:30
parent db7c5beea5
commit 2449f268f2
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/ui.js
View File

@ -45,7 +45,7 @@ const UI = {
inhibitReconnect: true, inhibitReconnect: true,
reconnectCallback: null, reconnectCallback: null,
reconnectPassword: null, reconnectPassword: null,
firstReconnectTime: 0, firstReconnectTime: null,
async start(options={}) { async start(options={}) {
UI.customSettings = options.settings || {}; UI.customSettings = options.settings || {};
@ -962,8 +962,8 @@ const UI = {
UI.closePowerPanel(); UI.closePowerPanel();
} }
}, },
resetFirstReconnection(){ resetFirstReconnection() {
UI.firstReconnectTime = 0; UI.firstReconnectTime = null;
}, },
/* ------^------- /* ------^-------
@ -1125,20 +1125,20 @@ const UI = {
reconnect() { reconnect() {
UI.reconnectCallback = null; UI.reconnectCallback = null;
const maxTime = UI.getSetting('reconnect_max_time') ?? 600000; // default to 10 minutes => 10 * 60 * 1000 ms const MAX_RECONNECT_TIME_SECONDS = 10 * 60; // 10 * 60s
const MAX_TIME_IN_MS = MAX_RECONNECT_TIME_SECONDS * 1000;
// Initialize first reconnect time if it's the first attempt // Initialize first reconnect time if it's the first attempt
if (UI.firstReconnectTime === null) { if (UI.firstReconnectTime === null) {
UI.firstReconnectTime = Date.now(); UI.firstReconnectTime = Date.now();
} }
const elapsedTime = Date.now() - UI.firstReconnectTime;
// Check if we've exceeded the max reconnect time // Check if we've exceeded the max reconnect time
if ((Date.now() - UI.firstReconnectTime) >= maxTime) { if ((Date.now() - UI.firstReconnectTime) >= MAX_TIME_IN_MS) {
// hiding the previous status message // hiding the previous status message
UI.hideStatus(); UI.hideStatus();
// Showing this message for long time, because if the connection is unstable and user is not around to see the message when the connection is lost, they will be able to see it when they will come back. (Showing for 3 hours) // Showing this message for long time, because if the connection is unstable and user is not around to see the message when the connection is lost, they will be able to see it when they will come back. (Showing for 3 hours)
UI.showStatus(_("Maximum reconnect attempts reached. Failed to connect to the server."), 'error', 180*60*1000); UI.showStatus(_("Maximum reconnect attempts reached. Failed to connect to the server."), 'error', 180 * 60 * 1000);
UI.updateVisualState('disconnected'); UI.updateVisualState('disconnected');
return; return;
} }
@ -1175,7 +1175,6 @@ const UI = {
} }
UI.showStatus(msg); UI.showStatus(msg);
UI.updateVisualState('connected'); UI.updateVisualState('connected');
// Here we can reset the retry count
UI.resetFirstReconnection(); UI.resetFirstReconnection();
UI.updateBeforeUnload(); UI.updateBeforeUnload();

3
defaults.json
View File

@ -1,3 +0,0 @@
{
"reconnect_max_time": 600000
}