crabapples
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(h264): replace `self` with `this` in H264Context.decode() 

`self` refers to `window` in browser context, causing SPS parameters
to be set on the global object instead of the H264Context instance.
This prevents the decoder from ever being properly configured.
This commit is contained in:
keradoxchen 2026-02-09 02:36:50 +00:00
parent 6d0a974665
commit 3b76636bdf
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/decoders/h264.js
View File

@ -196,9 +196,9 @@ export class H264Context {
}
if (parser.profileIdc !== null) {
self._profileIdc = parser.profileIdc;
self._constraintSet = parser.constraintSet;
self._levelIdc = parser.levelIdc;
this._profileIdc = parser.profileIdc;
this._constraintSet = parser.constraintSet;
this._levelIdc = parser.levelIdc;
}
if (this._decoder === null || this._decoder.state !== 'configured') {
@ -206,12 +206,12 @@ export class H264Context {
Log.Warn("Missing key frame. Can't decode until one arrives");
continue;
}
if (self._profileIdc === null) {
if (this._profileIdc === null) {
Log.Warn('Cannot config decoder. Have not received SPS and PPS yet.');
continue;
}
this._configureDecoder(self._profileIdc, self._constraintSet,
self._levelIdc);
this._configureDecoder(this._profileIdc, this._constraintSet,
this._levelIdc);
}
result = this._preparePendingFrame(timestamp);