From 968431dd46246ea03d9d4c7f5c7be03ad7b0c88b Mon Sep 17 00:00:00 2001
From: samhed <samuel@cendio.se>
Date: Tue, 17 Sep 2013 15:01:52 +0200
Subject: [PATCH 1/7] Catch input events to make the onscreen keyboard work in
 chrome on android.

---
 include/ui.js | 45 ++++++++++++++++++++++++++++++++++++++++-----
 vnc.html      |  2 +-
 2 files changed, 41 insertions(+), 6 deletions(-)

diff --git a/include/ui.js b/include/ui.js
index b933d312..1dfc67cf 100644
--- a/include/ui.js
+++ b/include/ui.js
@@ -155,7 +155,8 @@ addMouseHandlers: function() {
     $D("noVNC_mouse_button2").onclick = function () { UI.setMouseButton(4); };
     $D("noVNC_mouse_button4").onclick = function () { UI.setMouseButton(0); };
     $D("showKeyboard").onclick = UI.showKeyboard;
-    //$D("keyboardinput").onkeydown = function (event) { onKeyDown(event); };
+
+    $D("keyboardinput").oninput = UI.keyInput;
     $D("keyboardinput").onblur = UI.keyInputBlur;
 
     $D("sendCtrlAltDelButton").onclick = UI.sendCtrlAltDel;
@@ -701,17 +702,51 @@ setViewDrag: function(drag) {
 
 // On touch devices, show the OS keyboard
 showKeyboard: function() {
+    var kbi, skb, l;
+    kbi = $D('keyboardinput');
+    skb = $D('showKeyboard');
+    l = kbi.value.length;
     if(UI.keyboardVisible === false) {
-        $D('keyboardinput').focus();
+        kbi.focus();
+        kbi.setSelectionRange(l, l); // Move the caret to the end
         UI.keyboardVisible = true;
-        $D('showKeyboard').className = "noVNC_status_button_selected";
+        skb.className = "noVNC_status_button_selected";
     } else if(UI.keyboardVisible === true) {
-        $D('keyboardinput').blur();
-        $D('showKeyboard').className = "noVNC_status_button";
+        kbi.blur();
+        skb.className = "noVNC_status_button";
         UI.keyboardVisible = false;
     }
 },
 
+// When keypress events are left uncought, catch the input events from
+// the keyboardinput element instead and send the corresponding key events.
+keyInput: function(event) {
+    var elem, input, len;
+    elem = $D('keyboardinput');
+    input = event.target.value;
+    len = (elem.selectionStart > input.length) ? elem.selectionStart : input.length;
+
+    if (len < 1) { // something removed?
+        UI.rfb.sendKey(0xff08); // send BACKSPACE
+    } else if (len > 1) { // new input?
+        for (var i = len-1; i > 0; i -= 1) {
+            // HTML does not consider trailing whitespaces as a part of the string
+            // and they are therefore undefined.
+            if (input[len-i] !== undefined) {
+                UI.rfb.sendKey(input.charCodeAt(len-i)); // send charCode
+            } else {
+                UI.rfb.sendKey(0x0020); // send SPACE
+            }
+        }
+    }
+
+    // In order to be able to delete text which has been written in
+    // another session there has to always be text in the
+    // keyboardinput element with which backspace can interact.
+    // We also need to reset the input field text to avoid overflow.
+    elem.value = "x";
+},
+
 keyInputBlur: function() {
     $D('showKeyboard').className = "noVNC_status_button";
     //Weird bug in iOS if you change keyboardVisible
diff --git a/vnc.html b/vnc.html
index 66b70259..89349f22 100644
--- a/vnc.html
+++ b/vnc.html
@@ -67,7 +67,7 @@
                     id="showKeyboard" class="noVNC_status_button"
                     value="Keyboard" title="Show Keyboard"/>
                 <input type="email" autocapitalize="off" autocorrect="off"
-                    id="keyboardinput" class=""/>
+                    id="keyboardinput" class="" value="&nbsp;"/>
             </div>
         </div>
 

From eb955f8c20b64991e90b2b6f04148a98f1fb9321 Mon Sep 17 00:00:00 2001
From: John Dewey <john@dewey.ws>
Date: Sat, 21 Sep 2013 12:19:09 -0700
Subject: [PATCH 2/7] The https check should come first

A similar change was made to ui.js in #252.
---
 vnc_auto.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/vnc_auto.html b/vnc_auto.html
index 2aa21889..bd905ffa 100644
--- a/vnc_auto.html
+++ b/vnc_auto.html
@@ -128,12 +128,12 @@
             // if port == 80 (or 443) then it won't be present and should be
             // set manually
             if (!port) {
-                if (window.location.protocol.substring(0,4) == 'http') {            
-                    port = 80;
-                }
-                else if (window.location.protocol.substring(0,5) == 'https') {            
+                if (window.location.protocol.substring(0,5) == 'https') {            
                     port = 443;
                 }
+                else if (window.location.protocol.substring(0,4) == 'http') {            
+                    port = 80;
+                }
             }
 
             // If a token variable is passed in, set the parameter in a cookie.

From 82744aa8ee760520dafad8a3bd299879927d3398 Mon Sep 17 00:00:00 2001
From: John Dewey <john@dewey.ws>
Date: Sat, 21 Sep 2013 12:19:59 -0700
Subject: [PATCH 3/7] Removed trailing white space terds

---
 vnc_auto.html | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/vnc_auto.html b/vnc_auto.html
index bd905ffa..7704bf69 100644
--- a/vnc_auto.html
+++ b/vnc_auto.html
@@ -2,7 +2,7 @@
 <html>
 <head>
 
-    <!-- 
+    <!--
     noVNC example: simple example using default UI
     Copyright (C) 2012 Joel Martin
     Copyright (C) 2013 Samuel Mannehed for Cendio AB
@@ -128,10 +128,10 @@
             // if port == 80 (or 443) then it won't be present and should be
             // set manually
             if (!port) {
-                if (window.location.protocol.substring(0,5) == 'https') {            
+                if (window.location.protocol.substring(0,5) == 'https') {
                     port = 443;
                 }
-                else if (window.location.protocol.substring(0,4) == 'http') {            
+                else if (window.location.protocol.substring(0,4) == 'http') {
                     port = 80;
                 }
             }

From 97aefe5f83e104eb27d0e8ac4dc08dad73e7315f Mon Sep 17 00:00:00 2001
From: samhed <samuel@cendio.se>
Date: Mon, 23 Sep 2013 11:48:16 +0200
Subject: [PATCH 4/7] Enables local cursor by default.

---
 include/ui.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/ui.js b/include/ui.js
index b933d312..35334cba 100644
--- a/include/ui.js
+++ b/include/ui.js
@@ -75,7 +75,7 @@ start: function(callback) {
     UI.initSetting('password', '');
     UI.initSetting('encrypt', (window.location.protocol === "https:"));
     UI.initSetting('true_color', true);
-    UI.initSetting('cursor', false);
+    UI.initSetting('cursor', true);
     UI.initSetting('shared', true);
     UI.initSetting('view_only', false);
     UI.initSetting('connectTimeout', 2);
@@ -356,8 +356,8 @@ toggleSettingsPanel: function() {
         if (UI.rfb.get_display().get_cursor_uri()) {
             UI.updateSetting('cursor');
         } else {
-            UI.updateSetting('cursor', false);
-            $D('noVNC_cursor').disabled = true;
+            UI.updateSetting('cursor', true);
+            $D('noVNC_cursor').disabled = false;
         }
         UI.updateSetting('clip');
         UI.updateSetting('shared');
@@ -518,8 +518,8 @@ updateVisualState: function() {
         UI.rfb.get_display().get_cursor_uri()) {
         $D('noVNC_cursor').disabled = connected;
     } else {
-        UI.updateSetting('cursor', false);
-        $D('noVNC_cursor').disabled = true;
+        UI.updateSetting('cursor', true);
+        $D('noVNC_cursor').disabled = false;
     }
     $D('noVNC_shared').disabled = connected;
     $D('noVNC_view_only').disabled = connected;

From 9b9e741b8cc5ebdd2754f4103ef54db864a347b2 Mon Sep 17 00:00:00 2001
From: samhed <samuel@cendio.se>
Date: Tue, 24 Sep 2013 11:19:17 +0200
Subject: [PATCH 5/7] On touch devices the default should be to use a remote
 cursor.

---
 include/ui.js | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/include/ui.js b/include/ui.js
index 35334cba..c3436dc6 100644
--- a/include/ui.js
+++ b/include/ui.js
@@ -24,6 +24,7 @@ connSettingsOpen : false,
 popupStatusOpen : false,
 clipboardOpen: false,
 keyboardVisible: false,
+isTouchDevice: false,
 
 // Setup rfb object, load settings from browser storage, then call
 // UI.init to setup the UI/menus
@@ -35,6 +36,8 @@ load: function (callback) {
 start: function(callback) {
     var html = '', i, sheet, sheets, llevels, port;
 
+    UI.isTouchDevice = 'ontouchstart' in document.documentElement;
+
     // Stylesheet selection dropdown
     sheet = WebUtil.selectStylesheet();
     sheets = WebUtil.getStylesheets();
@@ -75,7 +78,7 @@ start: function(callback) {
     UI.initSetting('password', '');
     UI.initSetting('encrypt', (window.location.protocol === "https:"));
     UI.initSetting('true_color', true);
-    UI.initSetting('cursor', true);
+    UI.initSetting('cursor', !UI.isTouchDevice);
     UI.initSetting('shared', true);
     UI.initSetting('view_only', false);
     UI.initSetting('connectTimeout', 2);
@@ -97,7 +100,7 @@ start: function(callback) {
     //    };
 
     // Show mouse selector buttons on touch screen devices
-    if ('ontouchstart' in document.documentElement) {
+    if (UI.isTouchDevice) {
         // Show mobile buttons
         $D('noVNC_mobile_buttons').style.display = "inline";
         UI.setMouseButton();
@@ -356,8 +359,8 @@ toggleSettingsPanel: function() {
         if (UI.rfb.get_display().get_cursor_uri()) {
             UI.updateSetting('cursor');
         } else {
-            UI.updateSetting('cursor', true);
-            $D('noVNC_cursor').disabled = false;
+            UI.updateSetting('cursor', !UI.isTouchDevice);
+            $D('noVNC_cursor').disabled = true;
         }
         UI.updateSetting('clip');
         UI.updateSetting('shared');
@@ -518,8 +521,8 @@ updateVisualState: function() {
         UI.rfb.get_display().get_cursor_uri()) {
         $D('noVNC_cursor').disabled = connected;
     } else {
-        UI.updateSetting('cursor', true);
-        $D('noVNC_cursor').disabled = false;
+        UI.updateSetting('cursor', !UI.isTouchDevice);
+        $D('noVNC_cursor').disabled = true;
     }
     $D('noVNC_shared').disabled = connected;
     $D('noVNC_view_only').disabled = connected;

From f8ddfc732da670dd8756f285ab409d7fdd8b477d Mon Sep 17 00:00:00 2001
From: samhed <samuel@cendio.se>
Date: Fri, 4 Oct 2013 17:59:03 +0200
Subject: [PATCH 6/7] Autoconnect option as URL query

---
 include/ui.js | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/include/ui.js b/include/ui.js
index b933d312..3449bc48 100644
--- a/include/ui.js
+++ b/include/ui.js
@@ -33,7 +33,7 @@ load: function (callback) {
 
 // Render default UI and initialize settings menu
 start: function(callback) {
-    var html = '', i, sheet, sheets, llevels, port;
+    var html = '', i, sheet, sheets, llevels, port, autoconnect;
 
     // Stylesheet selection dropdown
     sheet = WebUtil.selectStylesheet();
@@ -86,6 +86,15 @@ start: function(callback) {
                   'onUpdateState': UI.updateState,
                   'onClipboard': UI.clipReceive,
                   'onDesktopName': UI.updateDocumentTitle});
+
+    autoconnect = WebUtil.getQueryVar('autoconnect', false);
+    if (autoconnect === 'true' || autoconnect == '1') {
+        autoconnect = true;
+        UI.connect();
+    } else {
+        autoconnect = false;
+    }
+
     UI.updateVisualState();
 
     // Unfocus clipboard when over the VNC area
@@ -135,8 +144,10 @@ start: function(callback) {
         // Open the description dialog
         $D('noVNC_description').style.display = "block";
     } else {
-        // Open the connect panel on first load
-        UI.toggleConnectPanel();
+        // Show the connect panel on first load unless autoconnecting
+        if (autoconnect === UI.connSettingsOpen) {
+            UI.toggleConnectPanel();
+        }
     }
 
     // Add mouse event click/focus/blur event handlers to the UI

From 3346f9229b698d49c97baf98bdb6a31e310a7949 Mon Sep 17 00:00:00 2001
From: samhed <samuel@cendio.se>
Date: Wed, 9 Oct 2013 11:35:43 +0200
Subject: [PATCH 7/7] Fix so that parentheses can be written from iOS devices. 
    * changed the type of the input field (which is used for bringing up the  
     on-screen keyboards on touch devices) from email to text     * when
 typing in an input field of type email the user is not allowed to       write
 parentheses on iOS devices, the keys are disabled.     * tested on iOS 6, iOS
 7 and Android 4.3.

---
 vnc.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vnc.html b/vnc.html
index 89349f22..f85a27fb 100644
--- a/vnc.html
+++ b/vnc.html
@@ -66,7 +66,7 @@
                 <input type="image" src="images/keyboard.png"
                     id="showKeyboard" class="noVNC_status_button"
                     value="Keyboard" title="Show Keyboard"/>
-                <input type="email" autocapitalize="off" autocorrect="off"
+                <input type="text" autocapitalize="off" autocorrect="off"
                     id="keyboardinput" class="" value="&nbsp;"/>
             </div>
         </div>