From 27ee3534011dedaaeb5c85b333394fd5f94f14ca Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Wed, 16 Nov 2022 15:28:18 +0100 Subject: [PATCH] Don't include default message to send_error() Python can provide this for us, so avoid duplication. --- tests/test_websockifyserver.py | 4 ++-- websockify/websockifyserver.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/test_websockifyserver.py b/tests/test_websockifyserver.py index 4f46cb1..79d1b25 100644 --- a/tests/test_websockifyserver.py +++ b/tests/test_websockifyserver.py @@ -86,7 +86,7 @@ class WebSockifyRequestHandlerTestCase(unittest.TestCase): FakeSocket(b'GET /tmp.txt HTTP/1.1'), '127.0.0.1', server) handler.do_GET() - send_error.assert_called_with(405, ANY) + send_error.assert_called_with(405) @patch('websockify.websockifyserver.WebSockifyRequestHandler.send_error') def test_list_dir_with_file_only_returns_error(self, send_error): @@ -96,7 +96,7 @@ class WebSockifyRequestHandlerTestCase(unittest.TestCase): handler.path = '/' handler.do_GET() - send_error.assert_called_with(404, ANY) + send_error.assert_called_with(404) class WebSockifyServerTestCase(unittest.TestCase): diff --git a/websockify/websockifyserver.py b/websockify/websockifyserver.py index 3e13fa1..b1905bd 100644 --- a/websockify/websockifyserver.py +++ b/websockify/websockifyserver.py @@ -250,13 +250,13 @@ class WebSockifyRequestHandler(WebSocketRequestHandlerMixIn, SimpleHTTPRequestHa self.auth_connection() if self.only_upgrade: - self.send_error(405, "Method Not Allowed") + self.send_error(405) else: super().do_GET() def list_directory(self, path): if self.file_only: - self.send_error(404, "No such file") + self.send_error(404) else: return super().list_directory(path) @@ -277,7 +277,7 @@ class WebSockifyRequestHandler(WebSocketRequestHandlerMixIn, SimpleHTTPRequestHa self.auth_connection() if self.only_upgrade: - self.send_error(405, "Method Not Allowed") + self.send_error(405) else: super().do_HEAD()